Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70232
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.50 as permitted sender)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "internals@lists.php.net" <internals@lists.php.net>
References: <op.w56kvihzc9evq2@nikita2206-n56vj>
Date: Wed, 20 Nov 2013 15:30:45 +0400
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-ID: <op.w6uh9j0ic9evq2@nikita2206-n56vj>
In-Reply-To: <op.w56kvihzc9evq2@nikita2206-n56vj>
User-Agent: Opera Mail/12.16 (Linux)
Subject: Re: array_unique optional compare-callback proposal
From: inefedor@gmail.com ("Nikita Nefedov")

On Thu, 07 Nov 2013 17:24:44 +0400, Nikita Nefedov <inefedor@gmail.com>  
wrote:

> Hello,
>
> I would like to propose addition of a third (optional) argument for  
> array_unique which will be callback for comparing elements.
>
> There's a plenty of usecases for this. For example, what I've been  
> dealing with can be described like so:
>
> <?php
>
> $obj1 = new EntityName("asd");
> $obj2 = new EntityName("qwe");
>
> $a = [new EntityWrapper($obj1, ...), new EntityWrapper($obj2, ...), new  
> EntityWrapper($obj1, ...)];
>
> // now it can be solved like so:
>
> $newArray = [];
> foreach ($a as $e) {
>      $newArray[$e->getWrappedObject()->getIdentity()] = $e;
> }
>
> // but with this patch it can be solved with array_unique:
>
> $newArray = array_unique($a, SORT_USERDEFINED, function ($a, $b) {
>      return $a->getWrappedObject()->getIdentity() -  
> $b->getWrappedObject()->getIdentity();
> });
>
>
> Actually my problem was a little different but you get the idea... And I  
> think there will be even more usecases for this.
>
> Here's a patch for master branch with implementation of this proposal:  
> https://gist.github.com/nikita2206/7354392

Hello internals!

As long as there were no objections against this proposal I would like to  
make it into the 5.6.
Should this go through all RFC steps or can I just create a PR for it and  
expect it to be merged?