Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:7013 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57515 invoked by uid 1010); 12 Jan 2004 22:16:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 57467 invoked from network); 12 Jan 2004 22:16:16 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 12 Jan 2004 22:16:16 -0000 Received: (qmail 17654 invoked from network); 12 Jan 2004 22:16:08 -0000 Received: from guardian.zend.office (HELO andi-laptop.zend.com) (10.1.1.4) by int.zend.com with SMTP; 12 Jan 2004 22:16:08 -0000 Message-ID: <5.1.0.14.2.20040113001317.047d1e70@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 13 Jan 2004 00:16:02 +0200 To: internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: convert_to_writable_* From: andi@zend.com (Andi Gutmans) Any idea who added the following macros? zend_operators.h:#define convert_to_writable_ex_master(ppzv, lower_type, upper_type) \ zend_operators.h:#define convert_to_writable_boolean_ex(ppzv) convert_to_writable_ex_master(ppzv, boolean, BOOL) zend_operators.h:#define convert_to_writable_long_ex(ppzv) convert_to_writable_ex_master(ppzv, long, LONG) zend_operators.h:#define convert_to_writable_double_ex(ppzv) convert_to_writable_ex_master(ppzv, double, DOUBLE) zend_operators.h:#define convert_to_writable_string_ex(ppzv) convert_to_writable_ex_master(ppzv, string, STRING) zend_operators.h:#define convert_to_writable_array_ex(ppzv) convert_to_writable_ex_master(ppzv, array, ARRAY) zend_operators.h:#define convert_to_writable_object_ex(ppzv) convert_to_writable_ex_master(ppzv, object, OBJECT) zend_operators.h:#define convert_to_writable_null_ex(ppzv) convert_to_writable_ex_master(ppzv, null, NULL) They only seem to be used in imap/php_imap.c and they don't make very much sense to me. I'm not sure whoever wrote them and used it in php/imap.c knew what he was doing. Unless I hear something I will nuke them tomorrow and will fix the relevant line in php_imap.c to the best of my knowledge. /home/andi/php5/ext> grep convert_to_writable */*.c imap/php_imap.c: convert_to_writable_string_ex(arg); /* Is this string really modified? */ Andi