Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70035 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50598 invoked from network); 6 Nov 2013 16:42:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Nov 2013 16:42:12 -0000 X-Host-Fingerprint: 217.114.215.11 experimentalworks.net Date: Wed, 06 Nov 2013 11:42:12 -0500 Received: from [217.114.215.11] ([217.114.215.11:23740] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 67/00-50145-2617A725 for ; Wed, 06 Nov 2013 11:42:12 -0500 To: internals@lists.php.net References: <52796343.9020801@litespeedtech.com> User-Agent: slrn/pre1.0.0-18 (Linux) Message-ID: X-Posted-By: 217.114.215.11 Subject: Re: [PHP-DEV] cannot push to 5.x branches From: dsp@php.net (David Soria Parra) Hannes Magnusson schrieb: > On Tue, Nov 5, 2013 at 1:29 PM, George Wang wrote: >> Hi, >> >> I try to update sapi/litespeed code to the latest. Successfully pushed to >> master branch: >> >> remote: Welcome gwang. >> remote: Changesets accepted. Thank you for your contribution. >> remote: >> remote: Attempting to push to mirror git@github.com:php/php-src.git >> remote: To git@github.com:php/php-src.git >> remote: c4cfdfa..3720fd7 master -> master >> To git@git.php.net:php-src.git >> c4cfdfa..3720fd7 HEAD -> master >> >> but cannot push to 5.x branches. Got: >> >> remote: Welcome gwang. >> remote: You have insufficient Karma! >> remote: I'm sorry, I cannot allow you to write to >> remote: php-src.git/ >> remote: Have a nice day. >> To git@git.php.net:php-src.git >> ! [remote rejected] HEAD -> 5.3 (pre-receive hook declined) >> error: failed to push some refs to 'git@git.php.net:php-src.git' >> >> My .git/config: >> [core] >> repositoryformatversion = 0 >> filemode = true >> bare = false >> logallrefupdates = true >> [remote "origin"] >> url = git@git.php.net:php-src.git >> fetch = +refs/heads/*:refs/remotes/origin/* >> pushurl = git@git.php.net:php-src.git >> [branch "master"] >> remote = origin >> merge = refs/heads/master >> [branch "5.3"] >> remote = origin >> merge = refs/heads/PHP-5.3 >> [branch "5.4"] >> remote = origin >> merge = refs/heads/PHP-5.4 >> [branch "5.5"] >> remote = origin >> merge = refs/heads/PHP-5.5 >> >> Did I do anything wrong, or I just need more Karma? >> > > > You have karma for the litespeed sapi in php-src... master. > We do have a good chunk of people that only have access to specific > paths/extensions/sapis in php-src, I guess that doesn't work anymore > since the move to git.. > I am unsure how the avail line should be to include branches, or how > do modify the pre-receive hook to ignore branches when doing the path > check.. David? It works. We are checking the contents of the commit and all affected paths in order to allow writes or not. However if a person with insufficient karma merges he will get a reject during push as the merge might touch paths that he is not allowed to write to.