Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:70022 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88781 invoked from network); 5 Nov 2013 23:44:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Nov 2013 23:44:13 -0000 Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain oracle.com designates 141.146.126.69 as permitted sender) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 141.146.126.69 aserp1040.oracle.com Received: from [141.146.126.69] ([141.146.126.69:30326] helo=aserp1040.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8B/79-40963-CC289725 for ; Tue, 05 Nov 2013 18:44:12 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rA5Ni80X028554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Nov 2013 23:44:09 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA5Ni7RN016900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 5 Nov 2013 23:44:07 GMT Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA5Ni6hZ026365; Tue, 5 Nov 2013 23:44:06 GMT Received: from [130.35.70.238] (/130.35.70.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Nov 2013 15:44:06 -0800 Message-ID: <527982C6.2000308@oracle.com> Date: Tue, 05 Nov 2013 15:44:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: George Wang CC: "internals@lists.php.net" References: <52796343.9020801@litespeedtech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Subject: Re: [PHP-DEV] cannot push to 5.x branches From: christopher.jones@oracle.com (Christopher Jones) On 11/05/2013 03:27 PM, Hannes Magnusson wrote: > On Tue, Nov 5, 2013 at 1:29 PM, George Wang wrote: >> Hi, >> >> I try to update sapi/litespeed code to the latest. Successfully pushed to >> master branch: >> >> remote: Welcome gwang. >> remote: Changesets accepted. Thank you for your contribution. >> remote: >> remote: Attempting to push to mirror git@github.com:php/php-src.git >> remote: To git@github.com:php/php-src.git >> remote: c4cfdfa..3720fd7 master -> master >> To git@git.php.net:php-src.git >> c4cfdfa..3720fd7 HEAD -> master >> >> but cannot push to 5.x branches. Got: >> >> remote: Welcome gwang. >> remote: You have insufficient Karma! >> remote: I'm sorry, I cannot allow you to write to >> remote: php-src.git/ >> remote: Have a nice day. >> To git@git.php.net:php-src.git >> ! [remote rejected] HEAD -> 5.3 (pre-receive hook declined) >> error: failed to push some refs to 'git@git.php.net:php-src.git' >> >> My .git/config: >> [core] >> repositoryformatversion = 0 >> filemode = true >> bare = false >> logallrefupdates = true >> [remote "origin"] >> url = git@git.php.net:php-src.git >> fetch = +refs/heads/*:refs/remotes/origin/* >> pushurl = git@git.php.net:php-src.git >> [branch "master"] >> remote = origin >> merge = refs/heads/master >> [branch "5.3"] >> remote = origin >> merge = refs/heads/PHP-5.3 >> [branch "5.4"] >> remote = origin >> merge = refs/heads/PHP-5.4 >> [branch "5.5"] >> remote = origin >> merge = refs/heads/PHP-5.5 >> >> Did I do anything wrong, or I just need more Karma? >> > > > You have karma for the litespeed sapi in php-src... master. > We do have a good chunk of people that only have access to specific > paths/extensions/sapis in php-src, I guess that doesn't work anymore > since the move to git.. > I am unsure how the avail line should be to include branches, or how > do modify the pre-receive hook to ignore branches when doing the path > check.. David? > > > -Hannes > PHP 5.3 is in security-fix only mode. If you have a security fix then check with Johannes before merging. Otherwise don't merge to that branch. Maybe access is restricted - I don't know? PHP 5.4 is pretty stable, so I (personally) don't think a big change would be desirable on that branch even for a specialized SAPI. I'd prefer to encourage people to move to PHP 5.5. Chris -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html