Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:70009
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 74.125.82.176 cause and error)
MIME-Version: 1.0
In-Reply-To: <5e668c8603798c3187d78c36c9687fbb.squirrel@webmail.klapt.com>
References: <c35dcb527aee65fdc17f1a29aadd8d21.squirrel@webmail.klapt.com>
	<CA+9eiLskBJGsMuW_-Pc1Scf3s7edxvEAeoz-kjj95Ui7xZu89g@mail.gmail.com>
	<63d89379efdd7f2ba0bcf0b62d5025af.squirrel@webmail.klapt.com>
	<CA+9eiLt+HDQVcD5kc2DE0w+R=AYPt8PHQ9Tbdg0EwJRH52+RuA@mail.gmail.com>
	<7c830ad80d33e82eb5f1553d03a44c6d.squirrel@webmail.klapt.com>
	<CA+9eiLuYKKc34CnGw+zP4mCHHOm4Z-XxpnoYBExhV9NYZnJ5cA@mail.gmail.com>
	<1383099923.15492.36.camel@ghost>
	<CA+9eiLsUAs96LquVm+7MHLmM=ij53_ci2vucMcEYfVGygCAudw@mail.gmail.com>
	<CA+9eiLsp+UazB8ZBAdbrQ6DMNDAJGGFBc5EMzAiN--p6=JTzQQ@mail.gmail.com>
	<5e668c8603798c3187d78c36c9687fbb.squirrel@webmail.klapt.com>
Date: Tue, 5 Nov 2013 10:47:52 +0400
Message-ID: <CA+9eiLs3QBpCsnrWUfGFremfY1sE4SxHM=HJ67usboRjgOHa-Q@mail.gmail.com>
To: Anatol Belski <ab@php.net>
Cc: Pierre Joye <pierre.php@gmail.com>, PHP Internals <internals@lists.php.net>, 
	Andi Gutmans <andi@zend.com>, Zeev Suraski <zeev@zend.com>, Xinchen Hui <xinchen.h@zend.com>
Content-Type: multipart/alternative; boundary=047d7b6242526796fa04ea6869f0
Subject: Re: [PHP-DEV] Re: Fix for bug #50333
From: dmitry@zend.com (Dmitry Stogov)

--047d7b6242526796fa04ea6869f0
Content-Type: text/plain; charset=UTF-8

Hi Anatol,

I don't see any technical problems with the patch.

Thanks. Dmitry.



On Sat, Nov 2, 2013 at 4:45 PM, Anatol Belski <ab@php.net> wrote:

> Hi Dmitry,
>
> On Wed, October 30, 2013 13:00, Dmitry Stogov wrote:
> > Hi Anatol,
> >
> >
> > I've posted few comments at
> https://github.com/php/php-src/pull/500/files
> >  Otherwise, the patch looks fine.
> > I think it may be accepted even if it doesn't make visible improvement.
> > Of course, when the small issues described in comment are fixed.
> >
> >
> > There were also a minor merging conflict in ext/opcache/ZendAccelerator.c
> >  (it's not a problem at all).
> >
> >
> > I hope you testd ZTS PHP with patch well, because I mainly care about
> > non-ZTS builds.
> >
> > Thanks. Dmitry.
> >
>
> I've fixed the patch according to your last comments. Just a note about
> virtual_cwd_activate() being called twice. That is needed for the threaded
> environment, once for SAPI startup and then per request in
> zend_activate(), as that calls belong to different threads.
>
> The performance has at least no regressions, here's the report
>
>
> http://windows.php.net/downloads/snaps/ostc/pftt/perf/results-20131101-MasterVanilla-Master50333Patch2-2742.html
>
> The functional tests have also no regressions from recent master.
>
> Regards
>
> Anatol
>
>

--047d7b6242526796fa04ea6869f0--