Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69999
Return-Path: <ab@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 93636 invoked from network); 2 Nov 2013 12:45:12 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Nov 2013 12:45:12 -0000
Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender)
X-PHP-List-Original-Sender: ab@php.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:53895] helo=h1123647.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 23/83-56663-4D3F4725 for <internals@lists.php.net>; Sat, 02 Nov 2013 07:45:11 -0500
Received: by h1123647.serverkompetenz.net (Postfix, from userid 33)
	id 7080C23D60EE; Sat,  2 Nov 2013 13:45:05 +0100 (CET)
Received: from 178.10.182.85
        (SquirrelMail authenticated user anatol@belski.net)
        by webmail.klapt.com with HTTP;
        Sat, 2 Nov 2013 13:45:05 +0100
Message-ID: <5e668c8603798c3187d78c36c9687fbb.squirrel@webmail.klapt.com>
In-Reply-To:
 <CA+9eiLsp+UazB8ZBAdbrQ6DMNDAJGGFBc5EMzAiN--p6=JTzQQ@mail.gmail.com>
References: <c35dcb527aee65fdc17f1a29aadd8d21.squirrel@webmail.klapt.com>
    <CA+9eiLskBJGsMuW_-Pc1Scf3s7edxvEAeoz-kjj95Ui7xZu89g@mail.gmail.com>
    <63d89379efdd7f2ba0bcf0b62d5025af.squirrel@webmail.klapt.com>
    <CA+9eiLt+HDQVcD5kc2DE0w+R=AYPt8PHQ9Tbdg0EwJRH52+RuA@mail.gmail.com>
    <7c830ad80d33e82eb5f1553d03a44c6d.squirrel@webmail.klapt.com>
    <CA+9eiLuYKKc34CnGw+zP4mCHHOm4Z-XxpnoYBExhV9NYZnJ5cA@mail.gmail.com>
    <1383099923.15492.36.camel@ghost>
    <CA+9eiLsUAs96LquVm+7MHLmM=ij53_ci2vucMcEYfVGygCAudw@mail.gmail.com>
    <CA+9eiLsp+UazB8ZBAdbrQ6DMNDAJGGFBc5EMzAiN--p6=JTzQQ@mail.gmail.com>
Date: Sat, 2 Nov 2013 13:45:05 +0100
To: "Dmitry Stogov" <dmitry@zend.com>
Cc: "Pierre Joye" <pierre.php@gmail.com>,
 "PHP Internals" <internals@lists.php.net>,
 "Andi Gutmans" <andi@zend.com>,
 "Zeev Suraski" <zeev@zend.com>,
 "Xinchen Hui" <xinchen.h@zend.com>
Reply-To: "Anatol Belski" <ab@php.net>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: Fix for bug #50333
From: ab@php.net ("Anatol Belski")

Hi Dmitry,

On Wed, October 30, 2013 13:00, Dmitry Stogov wrote:
> Hi Anatol,
>
>
> I've posted few comments at https://github.com/php/php-src/pull/500/files
>  Otherwise, the patch looks fine.
> I think it may be accepted even if it doesn't make visible improvement.
> Of course, when the small issues described in comment are fixed.
>
>
> There were also a minor merging conflict in ext/opcache/ZendAccelerator.c
>  (it's not a problem at all).
>
>
> I hope you testd ZTS PHP with patch well, because I mainly care about
> non-ZTS builds.
>
> Thanks. Dmitry.
>

I've fixed the patch according to your last comments. Just a note about
virtual_cwd_activate() being called twice. That is needed for the threaded
environment, once for SAPI startup and then per request in
zend_activate(), as that calls belong to different threads.

The performance has at least no regressions, here's the report

http://windows.php.net/downloads/snaps/ostc/pftt/perf/results-20131101-MasterVanilla-Master50333Patch2-2742.html

The functional tests have also no regressions from recent master.

Regards

Anatol