Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69966 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32050 invoked from network); 30 Oct 2013 12:31:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Oct 2013 12:31:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:55705] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/D1-17074-02CF0725 for ; Wed, 30 Oct 2013 07:31:32 -0500 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id 5021523D60E3; Wed, 30 Oct 2013 13:31:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from [192.168.178.7] (dslb-178-007-121-182.pools.arcor-ip.net [178.7.121.182]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id B015C23D60E1; Wed, 30 Oct 2013 13:31:22 +0100 (CET) To: Dmitry Stogov Cc: Pierre Joye , PHP Internals , Andi Gutmans , Zeev Suraski , Xinchen Hui In-Reply-To: References: <63d89379efdd7f2ba0bcf0b62d5025af.squirrel@webmail.klapt.com> <7c830ad80d33e82eb5f1553d03a44c6d.squirrel@webmail.klapt.com> <1383099923.15492.36.camel@ghost> Content-Type: text/plain; charset="UTF-8" Date: Wed, 30 Oct 2013 13:31:18 +0100 Message-ID: <1383136278.15492.58.camel@ghost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Fix for bug #50333 From: ab@php.net (Anatol Belski) Hi Dmitry, On Wed, 2013-10-30 at 16:00 +0400, Dmitry Stogov wrote: > Hi Anatol, > > I've posted few comments at https://github.com/php/php-src/pull/500/files > Otherwise, the patch looks fine. > I think it may be accepted even if it doesn't make visible improvement. > Of course, when the small issues described in comment are fixed. > > There were also a minor merging conflict in ext/opcache/ZendAccelerator.c > (it's not a problem at all). > > I hope you testd ZTS PHP with patch well, because I mainly care about > non-ZTS builds. > > Thanks. Dmitry. thanks for the time you spend on this. The remaining fixes are on their way, they'll be tested well functionally+performance. I'll write back as soon as all that is done. What just comes in my mind, the original idea was invented on Solaris, so maybe there's something specific to that platform what makes it faster there. In the ticked is also mentioned "scalability on multi-threaded/multi-core systems", so maybe some more special conditions are needed. Maybe like some particular CPU cores count (currently we do it with 2 or 4 cores) or specific server load level. I'm going to play more with that. Best regards Anatol