Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69954
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62999 invoked from network); 29 Oct 2013 19:25:53 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 29 Oct 2013 19:25:52 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.217.171 mail-lb0-f171.google.com  
Received: from [209.85.217.171] ([209.85.217.171:41075] helo=mail-lb0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id F4/66-22922-FBB00725 for <internals@lists.php.net>; Tue, 29 Oct 2013 14:25:52 -0500
Received: by mail-lb0-f171.google.com with SMTP id x18so423720lbi.30
        for <internals@lists.php.net>; Tue, 29 Oct 2013 12:25:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=W8/A2yyLqN2QpFdbLOghmoKeoXTqj+9CKvi4Fy1LIiI=;
        b=JeO+l3A856eCnTPjf5K684tvMerz3rEWJcg4PEU5s2eKkmgC6vCttVUrfCriR12FkY
         drWWCRCb+5dHwLvCX8zRPVFg4EjhD3od5DoeVbYlsb3zhI0PUhamXbAXX1finpgRX9CP
         dyOEowZZxPYDuXEHKuYkQRhFnoTBKwXi8poRAvf7bDxw2GOLQVieKEd40jAbWWywOEZq
         usXxkRlyN9FfN5kdiIYNGtAsegdUkTXyfE+ZFjy8aZ4Qpin1kSogARv+myFhnH7rWcVr
         Ck72QEQLDMcY/vbdB1LfZmisYEoWh3tUSE5mA7uPzbUG+y83DLozp68ezyVUJ0z01tuu
         QvxA==
X-Received: by 10.152.116.109 with SMTP id jv13mr661743lab.30.1383074748215;
 Tue, 29 Oct 2013 12:25:48 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.112.154.201 with HTTP; Tue, 29 Oct 2013 12:25:08 -0700 (PDT)
In-Reply-To: <526FED0D.4040709@oracle.com>
References: <CAGa2bXbNFb0tV+Xqavz9m62RDxobey3BmyN0L7g9ATFxMS_KBA@mail.gmail.com>
 <CAGa2bXZkg6WTFHbgvC3J8M8R7qjZ3V5+pqG0Qe6tVVJ5i8iA1Q@mail.gmail.com> <526FED0D.4040709@oracle.com>
Date: Wed, 30 Oct 2013 04:25:08 +0900
X-Google-Sender-Auth: _G-GHBnGx26iYOYZ5xP4DBIbJDo
Message-ID: <CAGa2bXaE35zKnssEkfb7HY9_tYh=4Fu9Bju0FFP4hHSaU0VzZw@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3675e10b94804e9e62f38
Subject: Re: [PHP-DEV] Re: session_regenerate_id(true) by default
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c3675e10b94804e9e62f38
Content-Type: text/plain; charset=UTF-8

Hi Christopher,

On Wed, Oct 30, 2013 at 2:14 AM, Christopher Jones <
christopher.jones@oracle.com> wrote:

> If parameter omission is an issue, I think you should update the PHP
> function doc ASAP and explain the problem.
>
> Most E_DEPRECATED messages include the word "deprecated".  I think
> your message could be:
>
>   "Calling session_regenerate_id() without a parameter is
>    deprecated. Passing true is encouraged for better security"
>
> Can you review whether "false" should ever be an allowed value?
>
> The PHP doc could be improved to explain why someone might use true or
> false.
>
> FWIW, the message line in the RFC patch got truncated
>

Thank you!
 I'll fix them soon.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c3675e10b94804e9e62f38--