Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69907 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 73462 invoked from network); 27 Oct 2013 21:04:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Oct 2013 21:04:08 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:58246] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 25/41-45431-7CF7D625 for ; Sun, 27 Oct 2013 16:04:07 -0500 Received: by mail-la0-f48.google.com with SMTP id ev20so4601006lab.35 for ; Sun, 27 Oct 2013 14:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ksTn8sgwBoM2z4knbRLUMKCtLI5cQ7YlVUGo/YV0J5A=; b=Pva0/A0HmzwSdZubTFJ6vwbA3ykBkOp5wh+5X7TebxEvbLgqw0ctSK/r9N0ZwVbHn3 2RLzpgtNsmbRYXIfkCkbjcDWwdoB1Egbw8b7BJ6EYhTZzfm66cSvRlyWoI0eBugJnydj JRA2T/SiQvt8qoF6Q0MkC2XX9h0q8H7UODE7wzOdNc5+KxuCXXOpvRxKju7cKZVJWUL8 NFx2WAmX+MTHn7lSBK0hMEWEdydUsPIVFkVBsL115ytuiuBd1G69cNBQDtxh4fJWUXHX v+BCRcomThOa0wgi9NE7BdQuPioOdWc5zx1I3iCRvW2vc9sRxIN9HDd8tTXjxQdCs9ga a49A== X-Received: by 10.112.131.68 with SMTP id ok4mr8810291lbb.13.1382907843779; Sun, 27 Oct 2013 14:04:03 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.154.201 with HTTP; Sun, 27 Oct 2013 14:03:23 -0700 (PDT) In-Reply-To: <526CE2A2.9050408@php.net> References: <3E.D7.40084.12BBA625@pb1.pair.com> <526B554F.1020606@pthreads.org> <526CAF56.70908@pthreads.org> <526CC37D.9020505@php.net> <526CE2A2.9050408@php.net> Date: Mon, 28 Oct 2013 06:03:23 +0900 X-Google-Sender-Auth: Es1ti8U-5bUEUHkw49B705m4JVw Message-ID: To: Joe Watkins Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=047d7b343270c924aa04e9bf528d Subject: Re: [PHP-DEV] error_log binary unsafe From: yohgaki@ohgaki.net (Yasuo Ohgaki) --047d7b343270c924aa04e9bf528d Content-Type: text/plain; charset=UTF-8 Hi Joe, On Sun, Oct 27, 2013 at 6:53 PM, Joe Watkins wrote: > I don't see that it needs an RFC for the SAPI to have a means of logging > binary safe data. > > The implementations of FPM and Apache2 are things that might require RFC, > but I don't see that the basic CLI and CGI SAPI's do. > > So it might be best to merge as it is, with cli and cgi implemented for > reference, and then if someone wants to do the Apache2 and FPM > implementations they can, along with an RFC for them. > We need agreement patch that break compatibility/behavior, thus RFC is preferred. As long as we keep consistency, we could say it's not our business but it is users task handle it properly. I would vote some where between -1 to 0 to introduce needless inconsistency. Because users need conversion/escape anyway even if we make error logging binary safe. I'm not against making error logging binary safe, but I don't think we need inconsistency. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --047d7b343270c924aa04e9bf528d--