Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69887
Return-Path: <pthreads@pthreads.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 98209 invoked from network); 27 Oct 2013 06:14:55 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Oct 2013 06:14:55 -0000
Authentication-Results: pb1.pair.com smtp.mail=pthreads@pthreads.org; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=pthreads@pthreads.org; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain pthreads.org from 74.125.82.42 cause and error)
X-PHP-List-Original-Sender: pthreads@pthreads.org
X-Host-Fingerprint: 74.125.82.42 mail-wg0-f42.google.com  
Received: from [74.125.82.42] ([74.125.82.42:59429] helo=mail-wg0-f42.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id D0/47-45431-D5FAC625 for <internals@lists.php.net>; Sun, 27 Oct 2013 01:14:54 -0500
Received: by mail-wg0-f42.google.com with SMTP id n12so2311607wgh.3
        for <internals@lists.php.net>; Sat, 26 Oct 2013 23:14:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
         :subject:references:in-reply-to:content-type;
        bh=cvTPNMvPqZ6YAIOIzl24nVtU73SH2geKknmlgJo3jpA=;
        b=QA1ehSfv+LcVIAHfjv/qeqY+UnSZm2QVtqkISTuKsXHXM5kXF2LFBGjtyjumJUzF1M
         79U3ZJIbTyvixnWzU7tOTDAukJjx9/LEOWE4E5cucXS99A4rx7l7wLjRt5WshCGTV+fo
         iHmAdLHiJ6MLvZ2XYxJs6uZ2pyx6P/pIQcsl6ZrS6k8QOGP5DbWKu92WgnMO24w5An7G
         BW/ousR+CdBjleg/xANe4htkeRfgPYV9tJvdiWb6FgwszFrCqKEo6lhj5Qi5GmZWB41N
         Uyyeg20z0RE4NCVZlhtvKPE5A9k+ujlVh3+LJUs6b3sN415gZ1zzjv9r0qh7ZuCoIUw3
         0Yhw==
X-Gm-Message-State: ALoCoQk/u7t3fWJjtj8GeQPbEv8ceG0X1iLcn5SI98RG0lBg1RGrxTUfsPUAAu39WVH08Ow07lqT
X-Received: by 10.194.170.133 with SMTP id am5mr13615658wjc.42.1382854490910;
        Sat, 26 Oct 2013 23:14:50 -0700 (PDT)
Received: from [192.168.0.3] (cpc22-asfd3-2-0-cust209.1-2.cable.virginm.net. [80.4.21.210])
        by mx.google.com with ESMTPSA id ma3sm22682899wic.1.2013.10.26.23.14.48
        for <multiple recipients>
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Sat, 26 Oct 2013 23:14:50 -0700 (PDT)
Message-ID: <526CAF56.70908@pthreads.org>
Date: Sun, 27 Oct 2013 06:14:46 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Yasuo Ohgaki <yohgaki@ohgaki.net>, internals@lists.php.net
References: <3E.D7.40084.12BBA625@pb1.pair.com> <CAGa2bXYANkW6yDN2_UqncHWpM4Zv+DxMTX0W8kT5-83JAveZjw@mail.gmail.com> <526B554F.1020606@pthreads.org> <CAGa2bXaQ1pdObaN=1vva0QOaJPyZvr381T6riKcNYput51NawA@mail.gmail.com> <CAGa2bXba-kr8deWYVTNywTySz8Abg-YR1YO1WM_BxjZj30+jOQ@mail.gmail.com>
In-Reply-To: <CAGa2bXba-kr8deWYVTNywTySz8Abg-YR1YO1WM_BxjZj30+jOQ@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020204070100010107080701"
Subject: Re: [PHP-DEV] error_log binary unsafe
From: pthreads@pthreads.org (Joe Watkins)

--------------020204070100010107080701
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/26/2013 11:54 PM, Yasuo Ohgaki wrote:
> Hi Joe,
>
> On Sun, Oct 27, 2013 at 7:48 AM, Yasuo Ohgaki <yohgaki@ohgaki.net 
> <mailto:yohgaki@ohgaki.net>> wrote:
>
>     On Sat, Oct 26, 2013 at 2:38 PM, Joe Watkins
>     <pthreads@pthreads.org <mailto:pthreads@pthreads.org>> wrote:
>
>         Mail is not yet handled, TCP/IP is not supported any more,
>         streams are binary safe.
>         The SAPI and default error logging mechanism are all that
>         require attention.
>
>         The patch is not final and doesn't include a fix for every
>         implementation of SAPI.
>
>         I don't see the need for confusion ??
>
>
>     Generally speaking, I'm not against making functions/features
>     binary safe.
>
>     There are many implementations of syslog/SAPI and not sure if it
>     is good for all.
>     It could cause BC issue also. For example, application like OSSEC
>     HIDS detects
>     possible intrusion by analyzing logs. Patching SAPI may break
>     these applications.
>
>     I'm not against applying your patch to master, but it's not for
>     released versions.
>     We needs UPGRADE note if the patch is applied.
>
>
> I think it's good for master.
> Do you have commit karma?
> If not, I'm willing to merge your patch unless there are not objections.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net <mailto:yohgaki@ohgaki.net>

I don't have karma ...

There are lots of SAPI's, but this patch wasn't meant to implement them 
all, only to provide a route whereby they can implement binary safe 
log_message in the shape of log_message_ex.

The patch implements binsafe log for cli and cgi, do we need to 
implement any more ??

Cheers
Joe

--------------020204070100010107080701--