Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69883
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 66.111.4.28 as permitted sender)
Message-ID: <526C16B7.4090801@php.net>
Date: Sat, 26 Oct 2013 14:23:35 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Nikita Popov <nikita.ppv@gmail.com>, 
 PHP internals <internals@lists.php.net>
References: <CAF+90c8OgW4Nonaz+HQn+gi4r+AdaEMXsTxCAhn=WO-+aQQsZQ@mail.gmail.com>
In-Reply-To: <CAF+90c8OgW4Nonaz+HQn+gi4r+AdaEMXsTxCAhn=WO-+aQQsZQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Exceptions in the engine
From: cpriest@php.net (Clint Priest)

On 10/24/2013 12:41 PM, Nikita Popov wrote:
>      https://wiki.php.net/rfc/engine_exceptions
Very nice Nikita...

I like that this patch would provide for very little BC breakage. Given 
Rowan's list, there would be some changes in behavior but I think that 
the behavior would be desirable for those that have written their code 
in this manner (that finally's and destructors will be called, etc).

It might even be likely that those who have written code in this manner 
are not aware that their code isn't being unwound properly, I've run 
across situations like this before and am always a little leery of 
writing code that relies on destructors being called since it is not 
perfectly reliable.

On the potential issues:
  +1 for BaseException
  -1 for E_RECOVERABLE becoming exceptions because of the BC breakage 
(execution flow should continue on the next line)
  +1 for the final error message being reduced to Uncaught 
EngineException...
  -1 for not all errors converted, if it's an error that occurs after 
code execution has begun then they should all be converted for consistency.

On other ideas presented as comments:
  -1 for changing any current errors that let code execution continue 
(E_WARNING, E_NOTICE, etc) into exceptions.

In the end, I think that the current RFC takes it to where it really 
needs to be: proper unwinding of finally/destructors, better uncaught 
fatal error information (stack traces).  Some other languages go way too 
far with exceptions and make writing anything in them consist of 30% of 
the code being try/catch blocks rather than real code.

The only thing I would suggest is that it not being a single 
EngineException, but a few well thought out sub-classes of EngineException.

-Clint