Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69875
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
Message-ID: <526BB309.4030106@gmail.com>
Date: Sat, 26 Oct 2013 13:18:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAF+90c8OgW4Nonaz+HQn+gi4r+AdaEMXsTxCAhn=WO-+aQQsZQ@mail.gmail.com> <52699FB5.20300@garfieldtech.com> <526A6BCC.3060502@php.net> <526AC472.8060607@sugarcrm.com> <526AC950.7020605@php.net>
In-Reply-To: <526AC950.7020605@php.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Exceptions in the engine
From: rowan.collins@gmail.com (Rowan Collins)

On 25/10/2013 20:41, Joe Watkins wrote:
> If we really wanted to, we could fix all the code that throws the base 
> Exception, making them throw specialized types, as they should

This seems a little contradictory when you're proposing an 
undifferentiated EngineException, where individual errors would need to 
be distinguished based on the message string. That's pretty much what 
throw Exception('Some message'); gives in userland.

Besides which...

> and include a compiler check that finds catch(Exception) blocks and 
> complains, it shouldn't really be valid

I don't think "catch(Exception)" blocks exist as a partner to "throw 
Exception;" they exist to mark a boundary in code that you don't want 
any exceptions to cross, or where you want to log all exceptions in some 
bespoke way. They might be the last in a long string of catch() blocks 
attached to one try, like the default: label in a switch statement. They 
might also, as discussed wrt assertions/expectations, be in a unit 
testing framework.

-- 
Rowan Collins
[IMSoP]