Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69826
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.169 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU5AGK2SGHqfpxAri+CwRrwz2E+k8Ad2gvk-dikQnC0_ZA@mail.gmail.com>
References: <CA+9eiLtNLdrP-b5YymTfnEpMVhUXDHhZ7u15mbjyNNv9Ev1ePQ@mail.gmail.com>
	<52686702.80107@oracle.com>
	<CAEZPtU5AGK2SGHqfpxAri+CwRrwz2E+k8Ad2gvk-dikQnC0_ZA@mail.gmail.com>
Date: Thu, 24 Oct 2013 10:36:35 +0400
Message-ID: <CA+9eiLs8L9eJ-uLAERhKe64kxgYkQ4gx7mU7Vcdca7M0LyoRew@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Christopher Jones <christopher.jones@oracle.com>, 
	"Matt Ficken (Insight Global)" <v-mafick@microsoft.com>, Julien Pauli <jpauli@php.ne>, David Soria Parra <dsp@php.ne>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0435c008ecaf1c04e976da22
Subject: Re: [PHP-DEV] Improved performance of array_maerge() and func_get_args()
From: dmitry@zend.com (Dmitry Stogov)

--f46d0435c008ecaf1c04e976da22
Content-Type: text/plain; charset=UTF-8

On Thu, Oct 24, 2013 at 9:25 AM, Pierre Joye <pierre.php@gmail.com> wrote:

> hi,
>
> On Thu, Oct 24, 2013 at 2:17 AM, Christopher Jones
> <christopher.jones@oracle.com> wrote:
> >
> >
> > On 10/23/2013 05:36 AM, Dmitry Stogov wrote:
> >>
> >> Hi,
> >>
> >> I'm proposing two simple patches that eliminate a lot of useless zval
> >> copying.
> >> For example they remove only about 800 calls to zend_hash_copy() (25%)
> on
> >> each request to wordpress-3.6.0 home page and make it 2-4% faster.
> >>
> >> It's not a questions about master branch, but I think it is also safe to
> >> commit them into PHP-5.4 and PHP-5.5.
> >>
> >> Any objections?
> >>
> >> https://gist.github.com/dstogov/7117623
> >>
> >> https://gist.github.com/dstogov/7117649
> >>
> >> Thanks. Dmitry.
> >>
> >
> > I'd prefer PHP 5.4 was kept stable.
> >
> > Last time I suggested keeping PHP 5.4 stable [1], it wasn't, and the
> result
> > was
> > a performance regression [2].
>
> I tend to agree with Chris here, even for 5.5 :)
>

I don't care a lot about 5.4, but think it should be fixed in 5.5.

>
>
> However, Let me ask Matt to run our full tests suite against your
> patch, that may give us some numbers to discuss or confirm the safety
> of this patch.
>

Of course we checked patch with PHPT tests and some real-life apps, but in
case you have any other test suites it would be a great help to run them
too.

I would also look into strtr() implementation that became 6 times slower on
typical usage in comparison to 5.3 after its "improvement" :(

<?php
function foo() {
    for ($i = 0; $i < 100000; $i++) {
        strtr("abcdefgh", array("a"=>"11", "g"=>"22"));
    }
}
foo();
?>

Thanks. Dmitry.


>
> Matt? Can you run pftt, apps compat and perf tests using this patch pls?
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org
>

--f46d0435c008ecaf1c04e976da22--