Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69816
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.212.182 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Nor35uyirG_gp6xExPxYbv_4WE+G9KVE+O_pyAxR63sXQ@mail.gmail.com>
References: <CA+9eiLtNLdrP-b5YymTfnEpMVhUXDHhZ7u15mbjyNNv9Ev1ePQ@mail.gmail.com>
	<CAFMT4Nor35uyirG_gp6xExPxYbv_4WE+G9KVE+O_pyAxR63sXQ@mail.gmail.com>
Date: Wed, 23 Oct 2013 23:20:43 +0400
Message-ID: <CA+9eiLuM=Y+9Y86V7YyS3+2bS74yCMxyQAs1TY2OAhSr6KXaTQ@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Julien Pauli <jpauli@php.ne>, David Soria Parra <dsp@php.ne>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bf10aa8d693be04e96d6932
Subject: Re: [PHP-DEV] Improved performance of array_maerge() and func_get_args()
From: dmitry@zend.com (Dmitry Stogov)

--047d7bf10aa8d693be04e96d6932
Content-Type: text/plain; charset=UTF-8

On Wed, Oct 23, 2013 at 6:21 PM, Levi Morrison <morrison.levi@gmail.com>wrote:

>
> I'm proposing two simple patches that eliminate a lot of useless zval
>> copying.
>> For example they remove only about 800 calls to zend_hash_copy() (25%) on
>> each request to wordpress-3.6.0 home page and make it 2-4% faster.
>>
>
> Sounds great. Thank you for looking into this. Just to clarify: the
> wordpress improvements were from both patches, yes?
>

Yes, both patches together.


>
>>
>> It's not a questions about master branch, but I think it is also safe to
>> commit them into PHP-5.4 and PHP-5.5.
>>
>> Any objections?
>>
>
> I don't have an objection; I just want to reiterate that changing code can
> introduce BC breaks and to be careful when backporting it. Just be careful.
>

Of course we checked them careful for possible BC breaks, but we may miss
some special cases.

Thanks. Dmitry.

--047d7bf10aa8d693be04e96d6932--