Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69807
Return-Path: <morrison.levi@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 61455 invoked from network); 23 Oct 2013 14:21:05 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Oct 2013 14:21:05 -0000
Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.51 as permitted sender)
X-PHP-List-Original-Sender: morrison.levi@gmail.com
X-Host-Fingerprint: 209.85.219.51 mail-oa0-f51.google.com  
Received: from [209.85.219.51] ([209.85.219.51:47650] helo=mail-oa0-f51.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id B0/5D-10840-05BD7625 for <internals@lists.php.net>; Wed, 23 Oct 2013 10:21:05 -0400
Received: by mail-oa0-f51.google.com with SMTP id h1so874600oag.10
        for <internals@lists.php.net>; Wed, 23 Oct 2013 07:21:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=odVapN5+NlAn2M3qOSX4eUq/AcNe8JNtnHudiHLM+Hk=;
        b=Yczt+S/JxJtMrfvzrStLh8trEs5B6C660BPZ/aA1420N/NEE84BhmsXmulAd/quUas
         X0Rf8bUABR1hmwu6Je4ovDZGlCTrw1IQCBwd7Q2uRWYt3dulYXGJnXMrJdblN6JibLPx
         yVDwiJ18WeRDhP7dGf6ZVs0xTRfOduY2VkSsFnm0a9BgLEGrAlEF/vXmpg//2S82WqXE
         3SdVWq7gWpxSfCchQJ+J9i/n/UcfkMKR+6nHPySrh1DxDrXNyqNMWx6r7BSKUGzVnJO4
         HAqRS0uzElzpyr2jzvEM2AyNI19jUAKAaroo8NUo6onK65SHbwsXk1bpC8FJTsQOpQGM
         68Vg==
MIME-Version: 1.0
X-Received: by 10.60.115.10 with SMTP id jk10mr1817054oeb.74.1382538061860;
 Wed, 23 Oct 2013 07:21:01 -0700 (PDT)
Received: by 10.76.12.135 with HTTP; Wed, 23 Oct 2013 07:21:01 -0700 (PDT)
In-Reply-To: <CA+9eiLtNLdrP-b5YymTfnEpMVhUXDHhZ7u15mbjyNNv9Ev1ePQ@mail.gmail.com>
References: <CA+9eiLtNLdrP-b5YymTfnEpMVhUXDHhZ7u15mbjyNNv9Ev1ePQ@mail.gmail.com>
Date: Wed, 23 Oct 2013 08:21:01 -0600
Message-ID: <CAFMT4Nor35uyirG_gp6xExPxYbv_4WE+G9KVE+O_pyAxR63sXQ@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Julien Pauli <jpauli@php.ne>, David Soria Parra <dsp@php.ne>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0115eb5a10d4d704e9693afd
Subject: Re: [PHP-DEV] Improved performance of array_maerge() and func_get_args()
From: morrison.levi@gmail.com (Levi Morrison)

--089e0115eb5a10d4d704e9693afd
Content-Type: text/plain; charset=ISO-8859-1

> I'm proposing two simple patches that eliminate a lot of useless zval
> copying.
> For example they remove only about 800 calls to zend_hash_copy() (25%) on
> each request to wordpress-3.6.0 home page and make it 2-4% faster.
>

Sounds great. Thank you for looking into this. Just to clarify: the
wordpress improvements were from both patches, yes?


> It's not a questions about master branch, but I think it is also safe to
> commit them into PHP-5.4 and PHP-5.5.
>
> Any objections?
>

I don't have an objection; I just want to reiterate that changing code can
introduce BC breaks and to be careful when backporting it. Just be careful.

Again, good work.

--089e0115eb5a10d4d704e9693afd--