Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69806
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 74.125.82.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-LU9KY3Zaoq9eJPjssUAsSDTM9CJPoySak_=SFDmpT8g@mail.gmail.com>
References: <CA+9eiLtNLdrP-b5YymTfnEpMVhUXDHhZ7u15mbjyNNv9Ev1ePQ@mail.gmail.com>
	<CAF+90c-LU9KY3Zaoq9eJPjssUAsSDTM9CJPoySak_=SFDmpT8g@mail.gmail.com>
Date: Wed, 23 Oct 2013 18:00:20 +0400
Message-ID: <CA+9eiLsvvraWsPXhSFBZD7Me_d8dVLyHeFgMP74XrqGv1Hij5Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Julien Pauli <jpauli@php.ne>, David Soria Parra <dsp@php.ne>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b6251b0112a2604e968f074
Subject: Re: [PHP-DEV] Improved performance of array_maerge() and func_get_args()
From: dmitry@zend.com (Dmitry Stogov)

--047d7b6251b0112a2604e968f074
Content-Type: text/plain; charset=UTF-8

makes sense. thanks :)

Dmitry.


On Wed, Oct 23, 2013 at 5:52 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Wed, Oct 23, 2013 at 2:36 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi,
>>
>> I'm proposing two simple patches that eliminate a lot of useless zval
>> copying.
>> For example they remove only about 800 calls to zend_hash_copy() (25%) on
>> each request to wordpress-3.6.0 home page and make it 2-4% faster.
>>
>> It's not a questions about master branch, but I think it is also safe to
>> commit them into PHP-5.4 and PHP-5.5.
>>
>> Any objections?
>>
>> https://gist.github.com/dstogov/7117623
>>
>> https://gist.github.com/dstogov/7117649
>>
>> Thanks. Dmitry.
>>
>
> No objection, just quick note on func_get_args patch: You can use
> SEPARATE_ARG_IF_REF there, so the code in the loop body is:
>
>     zval *arg = *(p-(arg_count-i));
>     SEPARATE_ARG_IF_REF(arg);
>     zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &arg,
> sizeof(zval *), NULL);
>
> Nikita
>

--047d7b6251b0112a2604e968f074--