Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69795
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYfQEuk90HfVMZdSBZB7c9SnsYRT7t_G1K63xAyeeFKUA@mail.gmail.com>
References: <52603390.7020609@ajf.me>
	<CAPwsocH_4LUFXriCqTcfvOb4r5vdqqKEnE3SR=qzR5yD7Zt0nw@mail.gmail.com>
	<5266E5D0.3090506@ajf.me>
	<CAGa2bXaJX4_WdOS-6crzUY5r5iqe-Oyv1B50kViBD=g+oSOq8Q@mail.gmail.com>
	<526712D2.7080100@ajf.me>
	<CAGa2bXb8Mgp3R5y8E1KFMwSgSWSfhkd8kRKrOdkOeg88ftoMSA@mail.gmail.com>
	<526717C5.6020509@ajf.me>
	<CAGa2bXYfQEuk90HfVMZdSBZB7c9SnsYRT7t_G1K63xAyeeFKUA@mail.gmail.com>
Date: Wed, 23 Oct 2013 04:19:53 +0200
Message-ID: <CAH-PCH4EoN+pkGY6V+eZYjYgMt9O_ZNf6mo34BwkA4zuMfC5og@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc117215978904e95f2744
Subject: Re: [PHP-DEV] [PATCH] Add apache_request_headers() and
 apache_response_headers() to the CLI server
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7bdc117215978904e95f2744
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 23, 2013 at 3:20 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Andrea,
>
> On Wed, Oct 23, 2013 at 9:26 AM, Andrea Faulds <ajf@ajf.me> wrote:
>
> > But it already exists. Why add *another* alias? We should make
> > apache_response_headers() have a consistent alias, something like
> > getresponseheaders(). Then we'll have:
> >
> > * apache_request_headers() and getallheaders()
> > * apache_response_headers() and getresponseheaders()
> >
> > Under your proposal, we'd have:
> >
> > * apache_request_headers(), sapi_request_headers(), and getallheaders()
> > * apache_response_headers() and sapi_response_headers()
> >
>
> It is not good idea introducing non-standard function name in new release=
s.
> getallheaders() should be depreciated in the future as it does not confor=
m
> current naming convention.
>
> How about this?
>
> PHP 5.6: Document getallhaeders() as deprecated.
> PHP 5.7: Raise deprecated error for getallheaders().
> PHP 6.x: Remove getallheaders() adoption is done. (Perhaps 5 or 10 years
> from now?)
>
> It would be nicer cleaning up mess in the long run, rather than
> introducing new mess. IMHO.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

I would stick with the original proposal as it is a well understood and
self-contained feature with neglible/no BC break.
Handling the (possible) deprecation and removal of the apache_ functions
should be a separate topic(if you start walking down on that path, you have
to also consider other functions like apache_child_terminate which is also
provided by the cgi-fastcgi SAPI) and should be given a bit more thought
and because of the BC implications it is also a longer process(as you also
mentioned yourself).
Thanks for your feedback!

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--047d7bdc117215978904e95f2744--