Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69794 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99387 invoked from network); 23 Oct 2013 01:21:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Oct 2013 01:21:23 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.173 mail-lb0-f173.google.com Received: from [209.85.217.173] ([209.85.217.173:43774] helo=mail-lb0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 80/B2-10840-29427625 for ; Tue, 22 Oct 2013 21:21:22 -0400 Received: by mail-lb0-f173.google.com with SMTP id w7so189286lbi.4 for ; Tue, 22 Oct 2013 18:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=XDWMZzrQOGcgZPLygRS/WYJr/7RUi0kF+43lBovfE5U=; b=bZ67C68bZ8bdEgsl50D0gBC8z1mkwg2Lrg6oP62vQWH+CZ1jC0qm/Qj/lwAWzVn9C8 3+nAfxbrSvwYO+uV6mf9iMh3uby+bTNEjQO/6PmEWpLxietWkVWg5NrsAUQ7KiQGg2JJ wWETXPpKO8OgJ6dAx+/fDQ9YPiy9HQKFFyzQBHrM79XQMT/W3kaa3A3giN4aJOYIUEdw mWONY6orUPPdLGefmJsoGvuCKExbt8b9RvBV5fk/OrQIpRUEdaNes72WIK+Tdzd0SRLf H2xCMPf4O1bFac0nODjT88zQkpackhxZsrvCBIcos10GDTr+GmqFrlskKzgFYlmHHHAY nW4g== X-Received: by 10.152.88.74 with SMTP id be10mr20166895lab.4.1382491279425; Tue, 22 Oct 2013 18:21:19 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.154.201 with HTTP; Tue, 22 Oct 2013 18:20:39 -0700 (PDT) In-Reply-To: <526717C5.6020509@ajf.me> References: <52603390.7020609@ajf.me> <5266E5D0.3090506@ajf.me> <526712D2.7080100@ajf.me> <526717C5.6020509@ajf.me> Date: Wed, 23 Oct 2013 10:20:39 +0900 X-Google-Sender-Auth: ymzcg7dTX7O0zwDn1vgvWPoXKTY Message-ID: To: Andrea Faulds Cc: PHP internals Content-Type: multipart/alternative; boundary=001a11c34e6c9d868204e95e5577 Subject: Re: [PHP-DEV] [PATCH] Add apache_request_headers() and apache_response_headers() to the CLI server From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c34e6c9d868204e95e5577 Content-Type: text/plain; charset=UTF-8 Hi Andrea, On Wed, Oct 23, 2013 at 9:26 AM, Andrea Faulds wrote: > But it already exists. Why add *another* alias? We should make > apache_response_headers() have a consistent alias, something like > getresponseheaders(). Then we'll have: > > * apache_request_headers() and getallheaders() > * apache_response_headers() and getresponseheaders() > > Under your proposal, we'd have: > > * apache_request_headers(), sapi_request_headers(), and getallheaders() > * apache_response_headers() and sapi_response_headers() > It is not good idea introducing non-standard function name in new releases. getallheaders() should be depreciated in the future as it does not conform current naming convention. How about this? PHP 5.6: Document getallhaeders() as deprecated. PHP 5.7: Raise deprecated error for getallheaders(). PHP 6.x: Remove getallheaders() adoption is done. (Perhaps 5 or 10 years from now?) It would be nicer cleaning up mess in the long run, rather than introducing new mess. IMHO. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c34e6c9d868204e95e5577--