Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69789 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90413 invoked from network); 23 Oct 2013 00:26:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Oct 2013 00:26:58 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 198.187.29.241 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 198.187.29.241 imap3-1.ox.registrar-servers.com Received: from [198.187.29.241] ([198.187.29.241:44274] helo=imap3-1.ox.registrar-servers.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/C0-10840-1D717625 for ; Tue, 22 Oct 2013 20:26:57 -0400 Received: from localhost (localhost [127.0.0.1]) by oxmail.registrar-servers.com (Postfix) with ESMTP id 3CCF12A006A for ; Tue, 22 Oct 2013 20:26:55 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap3.ox.registrar-servers.com Received: from oxmail.registrar-servers.com ([127.0.0.1]) by localhost (imap3.ox.registrar-servers.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bD-PN6PIM48F for ; Tue, 22 Oct 2013 20:26:55 -0400 (EDT) Received: from [192.168.0.200] (unknown [94.3.245.95]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by oxmail.registrar-servers.com (Postfix) with ESMTPSA id D292A2A0053 for ; Tue, 22 Oct 2013 20:26:54 -0400 (EDT) Message-ID: <526717C5.6020509@ajf.me> Date: Wed, 23 Oct 2013 01:26:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20100101 Thunderbird/25.0 MIME-Version: 1.0 To: PHP internals References: <52603390.7020609@ajf.me> <5266E5D0.3090506@ajf.me> <526712D2.7080100@ajf.me> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Add apache_request_headers() and apache_response_headers() to the CLI server From: ajf@ajf.me (Andrea Faulds) On 23/10/2013 01:21, Yasuo Ohgaki wrote: > > getallheaders() is not good name since it does not follow current naming > convention. > But it already exists. Why add *another* alias? We should make apache_response_headers() have a consistent alias, something like getresponseheaders(). Then we'll have: * apache_request_headers() and getallheaders() * apache_response_headers() and getresponseheaders() Under your proposal, we'd have: * apache_request_headers(), sapi_request_headers(), and getallheaders() * apache_response_headers() and sapi_response_headers() I'd much rather go with my own proposal. It avoids introducing a new set of aliases, but instead completes the existing one, however imperfect it may seem. Cheers, -- Andrea Faulds http://ajf.me/