Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69788
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.169 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <526712D2.7080100@ajf.me>
References: <52603390.7020609@ajf.me> <CAPwsocH_4LUFXriCqTcfvOb4r5vdqqKEnE3SR=qzR5yD7Zt0nw@mail.gmail.com>
 <5266E5D0.3090506@ajf.me> <CAGa2bXaJX4_WdOS-6crzUY5r5iqe-Oyv1B50kViBD=g+oSOq8Q@mail.gmail.com>
 <526712D2.7080100@ajf.me>
Date: Wed, 23 Oct 2013 09:21:18 +0900
Message-ID: <CAGa2bXb8Mgp3R5y8E1KFMwSgSWSfhkd8kRKrOdkOeg88ftoMSA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0158b86a6adee004e95d81d6
Subject: Re: [PHP-DEV] [PATCH] Add apache_request_headers() and
 apache_response_headers() to the CLI server
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--089e0158b86a6adee004e95d81d6
Content-Type: text/plain; charset=UTF-8

On Wed, Oct 23, 2013 at 9:05 AM, Andrea Faulds <ajf@ajf.me> wrote:

> On 23/10/2013 01:02, Yasuo Ohgaki wrote:
>
>>
>> I'm not following the discussion, but if name matters why don't you use
>> generic name
>> function and alias of it?
>>
>>
> There's already a generic alias of apache_request_headers(), namely
> getallheaders(). There's not yet one for apache_response_headers(), but I
> don't think it's within the scope of this request to add one. I might add
> one with a separate request, mind.


getallheaders() is not good name since it does not follow current naming
convention.
Why don't we have

 - sapi_request_headers()
 - sapi_response_headers()

or

 - http_request_headers()
 - http_response_headers()

Just an idea.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--089e0158b86a6adee004e95d81d6--