Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69762 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9580 invoked from network); 22 Oct 2013 11:38:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Oct 2013 11:38:47 -0000 Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.180 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.223.180 mail-ie0-f180.google.com Received: from [209.85.223.180] ([209.85.223.180:50399] helo=mail-ie0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5E/F1-10840-5C366625 for ; Tue, 22 Oct 2013 07:38:46 -0400 Received: by mail-ie0-f180.google.com with SMTP id e14so1433974iej.11 for ; Tue, 22 Oct 2013 04:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=tfbl/40tUzEVgRqye5ISyB3fqoivpccLtgAc16wjsZg=; b=u+ZvO2ODIhsj7SYvw8F2AOWVKzVgT9oNFLl7KsMnL2/lB6LBrOQYhoYqEdn1UxjfLU sN6GJg7E4wlcEyS/1jKczoz+WWwmjWFaLLLHfzxFtwPuvLMWEG+FJje4vAFIzjxafibd 7zGbyw8FEtPs+t2i1J6pHRbrJUrnERX+7paUHc0wX246tp8Ojd7rbzjga902CRUFwpu2 CSgJwkkZ3BGM33Rjg7Qw0Ifgp1hK/kNPLr96SOPJsnl9P63GRdXk2EP0blUVMnsD6bMS pxoFkAMUnnn+n7lM31k742lCeBVGYQQ9+UZ/yQy8NNyDZj8uSTZ4xZO/QCaftlOlaNmK ePXA== MIME-Version: 1.0 X-Received: by 10.50.27.102 with SMTP id s6mr12821192igg.7.1382441922616; Tue, 22 Oct 2013 04:38:42 -0700 (PDT) Received: by 10.50.73.42 with HTTP; Tue, 22 Oct 2013 04:38:42 -0700 (PDT) In-Reply-To: References: Date: Tue, 22 Oct 2013 13:38:42 +0200 Message-ID: To: Patrick Schaaf Cc: internals , Yasuo Ohgaki Content-Type: multipart/alternative; boundary=047d7b10d015b8684304e952d76e Subject: Re: [PHP-DEV] session_regenerate_id(true) by default From: tyra3l@gmail.com (Ferenc Kovacs) --047d7b10d015b8684304e952d76e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Oct 22, 2013 at 1:23 PM, Patrick Schaaf wrote: > > Am 22.10.2013 13:16 schrieb "Ferenc Kovacs" : > > > > > On Tue, Oct 22, 2013 at 1:10 PM, Patrick Schaaf wrote: > >> > >> BTW and a bit off-topic: is there a good reason for session_write_clos= e > not returning a success indicator? Right now it spams the log with a > misleading message, but gives me no chance (short of setting up a global > error handler to catch and handle that message) to see (and maybe retry / > use a fallback) on failure > > > > you could do @session_write_close() and error_get_last() instead of the > global handler, > > Oh, thanks, that's less of a pain. > don't forget to include NEW and the UPGRADING changes in the PR and some tests. > > but I think that it is a good idea and would be a trivial and backward > compatible change. > > Good. I'm on vacation this week, but will try to cook up a PR when I'm > back next week. About time I start to work on php-src instead of only > making remarks here :) Do you think this would need an RFC? > > best regards > Patrick > a short one would be sufficient, better to be safe than sorry. --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --047d7b10d015b8684304e952d76e--