Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69761 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7364 invoked from network); 22 Oct 2013 11:23:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Oct 2013 11:23:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=bof@bof.de; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=bof@bof.de; sender-id=pass Received-SPF: pass (pb1.pair.com: domain bof.de designates 80.242.145.70 as permitted sender) X-PHP-List-Original-Sender: bof@bof.de X-Host-Fingerprint: 80.242.145.70 mars.intermailgate.com Received: from [80.242.145.70] ([80.242.145.70:58394] helo=mars.intermailgate.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/81-10840-A1066625 for ; Tue, 22 Oct 2013 07:23:07 -0400 Received: (qmail 3338 invoked by uid 1009); 22 Oct 2013 13:23:03 +0200 Received: from 209.85.220.176 by mars (envelope-from , uid 89) with qmail-scanner-1.25-st-qms (clamdscan: 0.96.2/17988. spamassassin: 3.3.1. perlscan: 1.25-st-qms. Clear:RC:1(209.85.220.176):. Processed in 0.07702 secs); 22 Oct 2013 11:23:03 -0000 X-Antivirus-MYDOMAIN-Mail-From: bof@bof.de via mars X-Antivirus-MYDOMAIN: 1.25-st-qms (Clear:RC:1(209.85.220.176):. Processed in 0.07702 secs Process 3326) Received: from mail-vc0-f176.google.com (gmail@bof.de@209.85.220.176) by mars.intermailgate.com with RC4-SHA encrypted SMTP; 22 Oct 2013 13:23:03 +0200 Received: by mail-vc0-f176.google.com with SMTP id ia6so529326vcb.21 for ; Tue, 22 Oct 2013 04:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iQVQuABmuY6p/fhSSsfvygrr2p5FnNh7LlsvwVtliYQ=; b=d/enSDI4rLxD7kOotyoPpSPa9KTUEwc5M2c+SlUAzx7wxcBKq697lnSIl5xQ+uRkw6 PoLI5eLhxR6YezP3h2x+KWOFK0Hu+sBKx4NZkHcjRPUPys5ziEsdhHtKQbztmlRIOk9i owpxSg5JsUmcN5w1QdV6jPabpWt64LQxUCgyYZFmQnIZFqruprZ0lvk9d4JRo0eU/zRB 0tScbaThJNjPi5ocA5fpHIf7VqLRHkF5RhP9jgMDNhzVyxWwnLO6ehIyOvGwrnSVBZpD jxFX4EDG2Jo/AWoMgx8jPlRKPcwgHMxmaDSsDj/x0NYnEhxSooD1J1Cf6Ak2j9ejvL4j /ELA== MIME-Version: 1.0 X-Received: by 10.220.186.202 with SMTP id ct10mr14992866vcb.14.1382440982281; Tue, 22 Oct 2013 04:23:02 -0700 (PDT) Received: by 10.52.185.102 with HTTP; Tue, 22 Oct 2013 04:23:02 -0700 (PDT) Received: by 10.52.185.102 with HTTP; Tue, 22 Oct 2013 04:23:02 -0700 (PDT) In-Reply-To: References: Date: Tue, 22 Oct 2013 13:23:02 +0200 Message-ID: To: Ferenc Kovacs Cc: internals , Yasuo Ohgaki Content-Type: multipart/alternative; boundary=047d7b676fd0ac340404e9529f62 Subject: Re: [PHP-DEV] session_regenerate_id(true) by default From: bof@bof.de (Patrick Schaaf) --047d7b676fd0ac340404e9529f62 Content-Type: text/plain; charset=ISO-8859-1 Am 22.10.2013 13:16 schrieb "Ferenc Kovacs" : > > On Tue, Oct 22, 2013 at 1:10 PM, Patrick Schaaf wrote: >> >> BTW and a bit off-topic: is there a good reason for session_write_close not returning a success indicator? Right now it spams the log with a misleading message, but gives me no chance (short of setting up a global error handler to catch and handle that message) to see (and maybe retry / use a fallback) on failure > > you could do @session_write_close() and error_get_last() instead of the global handler, Oh, thanks, that's less of a pain. > but I think that it is a good idea and would be a trivial and backward compatible change. Good. I'm on vacation this week, but will try to cook up a PR when I'm back next week. About time I start to work on php-src instead of only making remarks here :) Do you think this would need an RFC? best regards Patrick --047d7b676fd0ac340404e9529f62--