Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69706 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64794 invoked from network); 19 Oct 2013 14:46:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Oct 2013 14:46:48 -0000 X-Host-Fingerprint: 80.4.21.210 cpc22-asfd3-2-0-cust209.1-2.cable.virginmedia.com Received: from [80.4.21.210] ([80.4.21.210:25103] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 84/A7-23638-75B92625 for ; Sat, 19 Oct 2013 10:46:47 -0400 To: internals@lists.php.net,Jakub Zelenka Message-ID: <52629B53.3050300@php.net> Date: Sat, 19 Oct 2013 15:46:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 References: <3D.BC.23638.84CA1625@pb1.pair.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Posted-By: 80.4.21.210 Subject: Re: [PHP-DEV] RFC: Expectations From: krakjoe@php.net (Joe Watkins) On 10/19/2013 03:43 PM, Jakub Zelenka wrote: > Hi, > > On Fri, Oct 18, 2013 at 10:46 PM, Joe Watkins wrote: > >> Evening Chaps, >> >> Following on from discussion regarding assertion API in PHP, the >> following RFC is now up for discussion: >> >> https://wiki.php.net/rfc/**expectations >> >> Please do point out any missing sections or information, so that >> it can be clarified as quickly as possible. >> >> I hope this conveys the idea a bit clearer to everyone ? >> >> Cheers >> Joe > > > I think it's a nice idea. However I am not so sure if it's worthy > introducing a new keyword 'except' which will break all existing code where > except is used as a function name, class name... Could it be actually > mentioned in the RFC that there is a new keyword? It's quite clear from the > examples but it would be nice if it could be specified as it's quite > important IMHO. > > In addition I have got more technical question about using ext functions in > engine. I saw that you used php_trim in zend_compile.c. Is it a good idea > to do that? Wouldn't be better to create a new function (for example > zend_str_trim) in the engine (zend_operator.c comes to my mind as it > contains zend_str_tolower and other similar function) and then use this > function by php_trim? > > Jakub > It would appear a new keyword is required. I wasn't sure about php_trim either, I'll see what can be done there ... Cheers Joe