Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69702
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52603390.7020609@ajf.me>
References: <52603390.7020609@ajf.me>
Date: Sat, 19 Oct 2013 12:45:13 +0200
Message-ID: <CAEZPtU5452pdruTAtKEWcg3boQ5N=dcim4pYN+OSHgDYpCG74g@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [PATCH] Add apache_request_headers() and
 apache_response_headers() to the CLI server
From: pierre.php@gmail.com (Pierre Joye)

hi!

On Thu, Oct 17, 2013 at 8:59 PM, Andrea Faulds <ajf@ajf.me> wrote:
> Hello all,
>
> I implemented FR #65917 (getallheaders() is not supported by the built-in
> web server). FR #65917 is actually my own feature request; I created it
> because I had tried to use it with the CLI server to test an application of
> mine, and it wasn't available. So I went and implemented it, and since
> apache_response_headers() complements it and was trivial to implement as
> well, I have also implemented that, by copying the FastCGI code.
>
> Pull request here: https://github.com/php/php-src/pull/496
>
> The intent is for this to be merged into master (and hopefully 5.6). The
> pull request updates NEWS and UPGRADING, as well as adding a test.
>
> Thanks for your time.

Good idea, it was missing for too long already.

I do not think we need a RFC for this addition as it is about bringing
the builtin webserver in sync with other SAPIs.

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org