Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69638
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.171 as permitted sender)
MIME-Version: 1.0
Sender: jdavidlists@gmail.com
In-Reply-To: <CAF+90c-s-tanQoYV+AzkjxWJ_crJPPxT4HJg4dfnaFMfx5i4gA@mail.gmail.com>
References: <D7.A0.22512.AE09F525@pb1.pair.com>
	<525FC834.4060501@php.net>
	<CAMUwpuRHpAB6ut8CZ2TJJF0oJJ7B1QfSP_+Nfv3sda=QoyWb-A@mail.gmail.com>
	<1534105.bNC2os93J1@rofl>
	<CALJZF3h75yw2=mETjyZz1=005XmwX1K2wHujfRMufu3QBL_rrg@mail.gmail.com>
	<525FDAC3.6060103@php.net>
	<CABXB=RTU=m-Ugkkk1gqa_HXRV_K7dPL3CEuyzDtY+EwQ8mD=aw@mail.gmail.com>
	<CAF+90c-s-tanQoYV+AzkjxWJ_crJPPxT4HJg4dfnaFMfx5i4gA@mail.gmail.com>
Date: Thu, 17 Oct 2013 12:06:40 -0400
Message-ID: <CABXB=RS_eDxTRmTqqPzwqhAcCH6BLjx82kNV3rafWiJXqocA1A@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Joe Watkins <krakjoe@php.net>, PHP internals <internals@lists.php.net>, 
	Michael Wallner <mike@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Assertions
From: j.david.lists@gmail.com (J David)

On Thu, Oct 17, 2013 at 11:51 AM, Nikita Popov <nikita.ppv@gmail.com> wrote=
:
> Nobody is arguing that assertions should be used as a control-flow
> structure. It's still most useful to implement them as exceptions. Apart
> from being a lot better integrated than fatal errors (in particular they
> have such fancy things like stacktraces...) exceptions can also be
> gracefully handled where necessary.

If it is useful to handle an assertion, then it wasn't an assertion.
The minute you talk about "handling" assertions they become a control
flow structure and cease to be assertions.

> PHPUnit will catch the exception and tell you that an assertion failed, b=
ut it will still be able to continue running the rest of the testsuite.
> A framework (or front controller in general) can easily catch the excepti=
on at the top level and display an appropriate debugging page (rather than =
doing ugly register_shutdown_function hacks that are necessary to have even=
 remotely graceful handling of fatals).
> A deamon or server will be able to process further requests, even if one =
particular had an assertion failure.

Those are three great examples of how assertions are frequently misused.

There are *many* cases where assertions are not useful.  That means
use a different tool in those cases (like an exception), not that
assertions should be made into shorthand for exception throwing.

That functionality is fine to have, just call it something else.

Thanks!