Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69628
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFp73XsGNT5As+AJsVxPBEeA7roDudG5UciG9bBYh9WkshJgFQ@mail.gmail.com>
References: <CAHZZLotdoP1cy=jMdUjrTjQqfggpVkRTXt5GzgX97k2ES5mQQQ@mail.gmail.com>
	<CAFMT4NoG_hQZMbgacjra5ks5AUfcSgDDWUwSqBQDGmwavZxV1Q@mail.gmail.com>
	<CAFp73XsGNT5As+AJsVxPBEeA7roDudG5UciG9bBYh9WkshJgFQ@mail.gmail.com>
Date: Thu, 17 Oct 2013 08:46:23 -0600
Message-ID: <CAFMT4NrovmfT=QRAv1o+SPSbGfQSn8ZCuCnKNQsEgg0sATzL2A@mail.gmail.com>
To: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>
Cc: Benjamin Schneider <benjamin.schneider.de@gmail.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c30350ba802d04e8f0e171
Subject: Re: [PHP-DEV] Proposal: Introduction of InvalidStateException
From: morrison.levi@gmail.com (Levi Morrison)

--001a11c30350ba802d04e8f0e171
Content-Type: text/plain; charset=ISO-8859-1

> > I would like to propose the introduction of an 'InvalidStateException'
>> > into the SPL extension. Within the existing exceptions I am not able
>> > to find a type that would represent a state error, throwable if a
>> > method has been invoked at an illegal or inappropriate time.
>>
>> Exceptions are one part of the SPL that are a nasty, poorly thought-out
>> mess (no offense to anyone who worked on it; this stuff is harder than
>> people realize). I am -1 on simply adding another exception to our mess,
>> but if we can clean it up then I might support it, depending on details.
>
>
> I'd love to listen your ideas/suggestions. Maybe we can implement an RFC
> to make it better.
> Without exposure to problems, there are no problems at all.
>
> I'm not saying it's perfect, but would love ideas on how we can improve
> it. =)
>

As an example of my idea of progress:
https://github.com/morrisonlevi/Ardent/blob/master/Exceptions.md

   - DomainException
   - FunctionException
   - LookupException (The two sub-classes here may be unnecessary; just one
   may do)
      - IndexException
      - KeyException
   - StateException
      - EmptyException
      - FullException
   - TypeException

Of course, this is not backwards compatible. It does, however, include a
StateException that is relevant here. I'm not implying that my exceptions
hierarchy is complete, but a good deal of thought and use has gone into
them so far.

--001a11c30350ba802d04e8f0e171--