Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69540
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALJZF3jLAGO-x-jUW9Oegi8x2Z6T6_h=PiEQU+egNg-Sv535Ug@mail.gmail.com>
References: <CAHMUw2Ez_6QHkSQ01NFcFnvks9nSLxdJ3VtUg2LpGsmxBJ-k2w@mail.gmail.com>
	<CALJZF3haN-JVOuMUYJdrNWbx04OH0Ev2biAMKLUpLksaUM1Vkw@mail.gmail.com>
	<CAHMUw2HjtDcbK0rv1v=4p3KBrqqM-_zs3SEOck4-kK+4rH18oA@mail.gmail.com>
	<CALJZF3jLAGO-x-jUW9Oegi8x2Z6T6_h=PiEQU+egNg-Sv535Ug@mail.gmail.com>
Date: Thu, 10 Oct 2013 21:12:18 +0800
Message-ID: <CAHMUw2HD07ooriLojFarkUJ+nG+YqSPoQ4Kb1jnHiJj7FnXkiw@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc9c525897ea04e862c0de
Subject: Re: [PHP-DEV] Failing builds on Travis
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--047d7bdc9c525897ea04e862c0de
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Oct 1, 2013 at 5:22 PM, Michael Wallner <mike@php.net> wrote:

> On 27 September 2013 09:38, Tjerk Meesters <tjerk.meesters@gmail.com>
> wrote:
> > Hi Mike,
> >
> > On Fri, Sep 27, 2013 at 3:27 PM, Michael Wallner <mike@php.net> wrote:
> >>
> >> On 27 September 2013 04:37, Tjerk Meesters <tjerk.meesters@gmail.com>
> >> wrote:
> >> > Hi,
> >> >
> >> > The success of builds on Travis seems to hinge on a particular test
> >> > case:
> >> >
> >> > ext/standard/tests/file/disk_free_space_basic.phpt
> >> >
> >> > It asserts that if a file is written to, the free space after the
> write
> >> > must always be lower than the previously recorded value.
> >> >
> >> > On a busy system the free space is affected by many factors that can
> >> > cause
> >> > this assertion to fail and thus developers get a nasty looking (X) on
> >> > their
> >> > pull requests.
> >> >
> >>
> >> I actually committed a fix some time ago and didn't see a build of
> >> PHP-5.5+ failing for that reason?
> >
> >
> > Ah, I just saw that you've changed the file size to 0xFFFF bytes now. The
> > fact that my topic branch is 2806 commits behind master probably has
> > something to do with that then ;-)
>
>
> Now you said it... it fails again. :) Feel free to adjust this test to
> be more robust.
>

Not sure if this counts: https://github.com/php/php-src/pull/484

I suppose you could argue that you could replace the whole implementation
by something that returns a random floating point value, but I reckon that
Travis is not the authority when it comes to release time, is it? :)

The only alternative I can see is to either compare its results with the
output of `df` (within error margins) or just make the file even bigger.
Not sure I like either of those ;-)


>
> Thank you!
>



-- 
--
Tjerk

--047d7bdc9c525897ea04e862c0de--