Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69477
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.51 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <524D31E1.1050103@fedoraproject.org>
References: <CAEKnhAEM+XijRRqjf6EpJBKHvxyShP3bHQ5E7CCcK6_MbFwHpg@mail.gmail.com>
	<524D31E1.1050103@fedoraproject.org>
Date: Thu, 3 Oct 2013 10:27:41 +0100
Message-ID: <CAEKnhAH3fZjc3QOJKjUFRzYmWogVR+B69HfCRnrqRsiO8w=Ntg@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc90be28674304e7d2cc9a
Subject: Re: [PHP-DEV] Streams constify API change in master leads to
 compilation warning for extensions
From: bukka@php.net (Jakub Zelenka)

--047d7bdc90be28674304e7d2cc9a
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

>
> -PHPAPI php_stream_wrapper *php_stream_locate_url_wrapper
>  (const char *path, char **path_for_open, int options TSRMLS_DC);
>
> +PHPAPI php_stream_wrapper *php_stream_locate_url_wrapper
>  (const char *path, const char **path_for_open, int options TSRMLS_DC);
>
> While is absolutly safe (and often useful) to switch from (char *) to
> (const char *), it is not with (char **)
>
> No compatibility in ever way.
> ... expected =91const char **=92 but argument is of type =91char **=92 ..=
.
> ... expected =91char **=92 but argument is of type =91const char **=92 ..=
.
>
> So I agree, this one could probably be reverted.
>
> As I found awful having to see more code like this (ex from twig)
>
> #if PHP_API_VERSION >=3D 20100412
>         zend_get_object_classname(object, (const char **) &class_name,
> &class_name_len TSRMLS_CC);
> #else
>         zend_get_object_classname(object, &class_name, &class_name_len
> TSRMLS_CC);
> #endif
>         return class_name;
> }
>
>
Yeah, this is just for (char **) -> (const char **)

I found this in php_stream_locate_url_wrapper. I think that this should be
changed to

PHPAPI php_stream_wrapper *php_stream_locate_url_wrapper (const char *path,
char **path_for_open, int options TSRMLS_DC);

There is a similar change for php_glob_stream_path_split but it doesn't
have any influence on extensions as it is a static function.

Sorry about the zpp comment. It really didn't make any sense! :)

Jakub

--047d7bdc90be28674304e7d2cc9a--