Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69465 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60795 invoked from network); 2 Oct 2013 18:41:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2013 18:41:09 -0000 Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.53 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.128.53 mail-qe0-f53.google.com Received: from [209.85.128.53] ([209.85.128.53:42500] helo=mail-qe0-f53.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/6E-23255-4C86C425 for ; Wed, 02 Oct 2013 14:41:09 -0400 Received: by mail-qe0-f53.google.com with SMTP id jy17so885221qeb.12 for ; Wed, 02 Oct 2013 11:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=oWT7Bt7EEwaSYJk+o83wCy+1SX5Vkn5C/R96eBUdPPQ=; b=Sgy0uL3lOE2Pbk+iWh3eqpSwf9/HXK+RnYM4ZZ4uVpWVnZJPeBWuuBJ/1pztN27clP xDXyve5/ae2kRYaKRZUw6TfW2qfFJsF7zsaYlXOR7PpAKXZlYw9Ds6uLrU86DdJMgfTM LRTQoyV3XN7hcRQQtqozF2hGdd9IcIIjnoLWisW0uVTemUbp0B+a48WikdfTcbrS+8Ox 2QR5KUpi6whQmS6uaN3TDPkLxTLtm7l6iSMSp8+2hatq7Tsfq9i4VtKUdK1vvXFjBVNy m5TR8S13TuufWq1hgxoM4fHdK+dxpKTxAf2XbjAZhWxS+ibLlY9Out29MB8PxP5vreJS vL1g== MIME-Version: 1.0 X-Received: by 10.49.104.5 with SMTP id ga5mr4626769qeb.53.1380739265676; Wed, 02 Oct 2013 11:41:05 -0700 (PDT) Sender: jakub.php@gmail.com Received: by 10.224.55.16 with HTTP; Wed, 2 Oct 2013 11:41:05 -0700 (PDT) Date: Wed, 2 Oct 2013 19:41:05 +0100 X-Google-Sender-Auth: _zOo6YMdY5RyW8ncC8VkygIi5u0 Message-ID: To: PHP internals list , andrey@php.net Content-Type: multipart/alternative; boundary=047d7b6dc152754c4304e7c669cb Subject: Streams constify API change in master leads to compilation warning for extensions From: bukka@php.net (Jakub Zelenka) --047d7b6dc152754c4304e7c669cb Content-Type: text/plain; charset=ISO-8859-1 Hi, I was wondering why stream API has been changed in this commit: https://github.com/php/php-src/commit/92d27ccb0574f901a107409a7fec92888fa2b82f Basically all char pointers have been constified. The thing is that this commit leads to compilation warning for many extensions. In my case I use php_stream_locate_url_wrapper and want to compile my extension (fann) without any warnings. Because this change is in master and not in 5.5-, I will have to add some ifdefs and cast it for 5.6+. The thing is that php_stream_locate_url_wrapper and other stream fuctions are often used for function parameters from zend_parse_parameters which are just char *. Then the values have to be casted. I understand that APIs should be improved and sometimes changes are necessary but in this case I have to ask a question. Was this change worthy to compilation warnings for many extensions? If not would it be possible to revert it? Thanks Jakub --047d7b6dc152754c4304e7c669cb--