Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69443 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92577 invoked from network); 2 Oct 2013 09:55:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2013 09:55:44 -0000 Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender) X-PHP-List-Original-Sender: mike.php.net@gmail.com X-Host-Fingerprint: 209.85.215.48 mail-la0-f48.google.com Received: from [209.85.215.48] ([209.85.215.48:37429] helo=mail-la0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FD/90-23255-F9DEB425 for ; Wed, 02 Oct 2013 05:55:43 -0400 Received: by mail-la0-f48.google.com with SMTP id er20so412044lab.35 for ; Wed, 02 Oct 2013 02:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+FHVr4d458VVkqASsdB2jPKv8pr6LdDDcZ5jFArMWqs=; b=KaABPRK4RrFMIYYlyHjF2Uowca4NwT/Cce2zqHD8L0v8VLUpD4NiaVicWRmcy7nl9B 6PIoZD1X8aqQtHo7zFTt0omSqk7F51366FTaCFGh0skI8kDOzjulFhbrngUVo86wOZdw ig4jgEp9W/xW+gNm7RYKatNJGLND4x1M9jCN2PWgwAsVEtJaQpYVu86TSSGMhj42tbF4 6n+vp/zwS4K19n5+oG/BT5p4zutYu1VyBpgXabooFTf2E7a0R1X7ZQuOmd2NdrXFnl5/ pNeW6NQNWm/Ycf9rxSasrVK9pdsg0oaxALD0I0XT9ma+vtHB7UGkkZmQhjRJI2rwI1ZK NYsw== MIME-Version: 1.0 X-Received: by 10.152.22.65 with SMTP id b1mr395061laf.46.1380707740113; Wed, 02 Oct 2013 02:55:40 -0700 (PDT) Sender: mike.php.net@gmail.com Received: by 10.114.184.19 with HTTP; Wed, 2 Oct 2013 02:55:40 -0700 (PDT) In-Reply-To: References: Date: Wed, 2 Oct 2013 11:55:40 +0200 X-Google-Sender-Auth: 6DmJC4nk18u4dGlWN4rOhpCdZTs Message-ID: To: Lior Kaplan Cc: Derick Rethans , PHP internals list Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Gnu/Hurd support From: mike@php.net (Michael Wallner) On 2 October 2013 11:39, Lior Kaplan wrote: > On Sat, Sep 28, 2013 at 3:44 PM, Lior Kaplan wrote: > >> On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans wrote: >> >>> And bug 31347 is that was a fix for a specific issue on Windows: >>> https://bugs.php.net/bug.php?id=31347 >>> >> >> The patch originates in Debian, and I can assure you that they don't build >> for Windows (: >> So that's a good point, thanks. >> >> We could probably test for ZEND_WIN32, or at least that's what I see at >> ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd >> support (commit f90483001236c863abe1070d05ee2214db5a0a97). >> >> If that sounds OK, I'll try to do the change (although I'm not a >> developer). >> > > Ping ? > > I need this feedback to try and suggest a fixed patch. > > (sorry, not a developer, just practicing general knowledge and what I see > in other commits). Turn it around to something like: $ git diff diff --git a/main/php.h b/main/php.h index 7c1f8fd..951a4d9 100644 --- a/main/php.h +++ b/main/php.h @@ -254,6 +254,10 @@ END_EXTERN_C() # endif #endif +#ifndef PATH_MAX +# define PATH_MAX MAXPATHLEN +#endif + #if defined(__GNUC__) && __GNUC__ >= 4 # define php_ignore_value(x) (({ __typeof__ (x) __x = (x); (void) __x; })) #else -- Regards, Mike