Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69429
Return-Path: <mike.php.net@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 80696 invoked from network); 1 Oct 2013 09:22:59 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 1 Oct 2013 09:22:59 -0000
Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.179 as permitted sender)
X-PHP-List-Original-Sender: mike.php.net@gmail.com
X-Host-Fingerprint: 209.85.217.179 mail-lb0-f179.google.com  
Received: from [209.85.217.179] ([209.85.217.179:46595] helo=mail-lb0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 36/90-11272-2749A425 for <internals@lists.php.net>; Tue, 01 Oct 2013 05:22:58 -0400
Received: by mail-lb0-f179.google.com with SMTP id x18so5538790lbi.24
        for <internals@lists.php.net>; Tue, 01 Oct 2013 02:22:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:date:message-id:subject
         :from:to:cc:content-type;
        bh=Ml89Auv0dwWmjTVBFdiCRuYB0MoFmZRGwqJahothGT0=;
        b=Ly+WAEbFltpqCnSAWTn16JlOyPdfisNBCip1AcSVqA6T8Tgrw3hp2qAevVm+g1veOA
         LijQiyejZGbQEZl3YzRt71yqJ8GQrI42lGxDKcjb+aL2m9rj6/USUY5m+P8Rp3djwe3S
         I3LPNeO/SiXWm/QqeNhxslASRYbNkVkkOWNFeXMZJxd1uL34JvibxxPPhP2vQ2jM2qxt
         NLZYM0BQuNRR41T8QmuR0H2sY6PN2Tw4HJ3tmePqF+EQGQErBf+3kkTSALww7Y9Eycau
         6JtzZnzNN0efrKilHOWf47/OzTSeETBlh+0VC148YOI5uVvZrj/upW2Uwlv4bM0TvKkF
         z7xw==
MIME-Version: 1.0
X-Received: by 10.112.190.1 with SMTP id gm1mr10246216lbc.30.1380619374946;
 Tue, 01 Oct 2013 02:22:54 -0700 (PDT)
Sender: mike.php.net@gmail.com
Received: by 10.114.184.19 with HTTP; Tue, 1 Oct 2013 02:22:54 -0700 (PDT)
In-Reply-To: <CAHMUw2HjtDcbK0rv1v=4p3KBrqqM-_zs3SEOck4-kK+4rH18oA@mail.gmail.com>
References: <CAHMUw2Ez_6QHkSQ01NFcFnvks9nSLxdJ3VtUg2LpGsmxBJ-k2w@mail.gmail.com>
	<CALJZF3haN-JVOuMUYJdrNWbx04OH0Ev2biAMKLUpLksaUM1Vkw@mail.gmail.com>
	<CAHMUw2HjtDcbK0rv1v=4p3KBrqqM-_zs3SEOck4-kK+4rH18oA@mail.gmail.com>
Date: Tue, 1 Oct 2013 11:22:54 +0200
X-Google-Sender-Auth: xlrL-_i_Xa6yClVxmfm5WcYC9QQ
Message-ID: <CALJZF3jLAGO-x-jUW9Oegi8x2Z6T6_h=PiEQU+egNg-Sv535Ug@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Failing builds on Travis
From: mike@php.net (Michael Wallner)

On 27 September 2013 09:38, Tjerk Meesters <tjerk.meesters@gmail.com> wrote:
> Hi Mike,
>
> On Fri, Sep 27, 2013 at 3:27 PM, Michael Wallner <mike@php.net> wrote:
>>
>> On 27 September 2013 04:37, Tjerk Meesters <tjerk.meesters@gmail.com>
>> wrote:
>> > Hi,
>> >
>> > The success of builds on Travis seems to hinge on a particular test
>> > case:
>> >
>> > ext/standard/tests/file/disk_free_space_basic.phpt
>> >
>> > It asserts that if a file is written to, the free space after the write
>> > must always be lower than the previously recorded value.
>> >
>> > On a busy system the free space is affected by many factors that can
>> > cause
>> > this assertion to fail and thus developers get a nasty looking (X) on
>> > their
>> > pull requests.
>> >
>>
>> I actually committed a fix some time ago and didn't see a build of
>> PHP-5.5+ failing for that reason?
>
>
> Ah, I just saw that you've changed the file size to 0xFFFF bytes now. The
> fact that my topic branch is 2806 commits behind master probably has
> something to do with that then ;-)


Now you said it... it fails again. :) Feel free to adjust this test to
be more robust.

Thank you!