Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH7ATEEKL-oAY0cLsNZnN_esb1QrwsA5g7AoFFe4vCP3zw@mail.gmail.com>
References: <CAH-PCH7-oZT7u0KB7bbDFNmZGeMiSUcU0-Shsp7rXmwaOb3muA@mail.gmail.com>
	<CAF+90c8RWqVackrxFp+wUqeMmAtoNOFDupf=Unb2+UqTy8H=MQ@mail.gmail.com>
	<CAH-PCH7ATEEKL-oAY0cLsNZnN_esb1QrwsA5g7AoFFe4vCP3zw@mail.gmail.com>
Date: Sun, 29 Sep 2013 19:13:16 +0200
Message-ID: <CAH-PCH4Po-ko-3sg2_UiOuzf402VsKwPsDixdyMZa-MNrRAvwQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>, Antony Dovgal <tony2001@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133b4c4e540c104e788d53c
Subject: Re: [PHP-DEV] handling non-fatal compile-time errors
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a1133b4c4e540c104e788d53c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 29, 2013 at 4:59 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

>
>
>
> On Sun, Sep 29, 2013 at 2:02 PM, Nikita Popov <nikita.ppv@gmail.com>wrote=
:
>
>> On Thu, Aug 8, 2013 at 5:11 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I've just bumped into https://bugs.php.net/bug.php?id=3D65322 recently,
>>> and I
>>> would like you get some opinions on the issue.
>>> Personally I think that it is a really bad design to introduce
>>> pedantic(E_STRICT) errors which can break basic functionality of the
>>> engine
>>> (calling the registered autoloader), so if there is no viable solution =
to
>>> make the autoloader work for these kind of errors, I would like to
>>> propose
>>> removing the offending errors and make it a rule to not add compile-tim=
e
>>> non-fatal errors until the problem is resolved.
>>>
>>
>> By the way, there is no problem per-se to allow autoloading there (neste=
d
>> compilation due to error handlers is properly handled), the reason it
>> currently has the in_compilation check there is to prevent all the class
>> lookups from the compiler to trigger the autoloader (the compiler makes
>> extensive use of zend_lookup_class, which sets use_autoload=3D1). If all
>> lookups in the compiler are changed to use zend_lookup_class_ex with
>> use_autoload=3D0 it might be possible to remove the condition there.
>>
>> Nikita
>>
>
> Thanks for the reply, about the requirement of the in_compilation check:
> even recent comments stated that it is because the compiler not being
> reentrant (see the last comments from
> https://bugs.php.net/bug.php?id=3D54054&edit=3D1).
> Personally I would be fine with the separate error level, but if we could
> allow the autoloader there, that would be fantastic
>
> --
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>

For the record: Nikita just fixed the issue:
http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3Df0c926564c5f7de9462d9ca7=
bd75014b14a63f56
_o_

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a1133b4c4e540c104e788d53c--