Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69407
Return-Path: <lior.k@zend.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 33345 invoked from network); 28 Sep 2013 13:44:57 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Sep 2013 13:44:57 -0000
Authentication-Results: pb1.pair.com header.from=lior.k@zend.com; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=lior.k@zend.com; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.219.47 cause and error)
X-PHP-List-Original-Sender: lior.k@zend.com
X-Host-Fingerprint: 209.85.219.47 mail-oa0-f47.google.com  
Received: from [209.85.219.47] ([209.85.219.47:50309] helo=mail-oa0-f47.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 43/A5-27958-55DD6425 for <internals@lists.php.net>; Sat, 28 Sep 2013 09:44:55 -0400
Received: by mail-oa0-f47.google.com with SMTP id i1so2856126oag.34
        for <internals@lists.php.net>; Sat, 28 Sep 2013 06:44:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=HKh//DyOU3z3kHw9mqrewrS4ugltX6rlCY+ArZD87Ls=;
        b=EpvjoZW16K8vauh8Hg630W/1LG4V5c7Bdk6Yo/v1e/a05TBbm5H+waNcA4jbg/suOQ
         Wj1OX+UHWhD7DJ+2BvlAzEb4LrHIBB9uJHDu5PfV+lhMz35Cc3fx+1P0mMt10Hk8D6Dv
         b0rGl/b4rTmmPBdKjrsX33k3yPHscsahk2CRdyZKbGFsh8TXL3t9XAZMCCwBBll2HNzp
         WLKZXo6NYPu4ldI4HoaIEuN8gJxRDFdm0dJxBrteOrzSS1ranHRZn9tFkQA8mybzZH7F
         W17wS+kC3De6ctQQoi6CvMLCrhI4ufHpNJeWtAGad7RCgB/6Q1jWD0kaBGGAvMkC0ulU
         sEGA==
X-Gm-Message-State: ALoCoQl5aLFgM3F3+8RnU2ZhF2EC9taDLEXJG6mfJ2VVgp1Yc9r/soZBIIrsM79Uea/WTy/NlC56UEIEEjDZoDzXkAbPexOQ+FmRe768Uw2upjTtwnw0IDAc269T4JxzDm96QLZvgujN
MIME-Version: 1.0
X-Received: by 10.60.51.196 with SMTP id m4mr10618231oeo.1.1380375891348; Sat,
 28 Sep 2013 06:44:51 -0700 (PDT)
Received: by 10.60.23.195 with HTTP; Sat, 28 Sep 2013 06:44:51 -0700 (PDT)
In-Reply-To: <alpine.DEB.2.10.1309281153410.5916@whisky.home.derickrethans.nl>
References: <CAPJnDK2TjzyfOq=ueAEKGRB8p2qj1R-a8qwkL+N9q_TobgyAwg@mail.gmail.com>
	<alpine.DEB.2.10.1309271401340.5168@whisky.home.derickrethans.nl>
	<CAPJnDK0cWDvWfwKRw3uKF4h0DLagEmYgrhfsXA1KUos_5M3_zQ@mail.gmail.com>
	<alpine.DEB.2.10.1309281153410.5916@whisky.home.derickrethans.nl>
Date: Sat, 28 Sep 2013 15:44:51 +0200
Message-ID: <CAPJnDK34kd80WHQmz11qhiqbU28PXXQuAqGDisXxCd6F-tZLXw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c30920a926e204e771ce7d
Subject: Re: [PHP-DEV] Gnu/Hurd support
From: lior.k@zend.com (Lior Kaplan)

--001a11c30920a926e204e771ce7d
Content-Type: text/plain; charset=UTF-8

On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans <derick@php.net> wrote:

> And bug 31347 is that was a fix for a specific issue on Windows:
> https://bugs.php.net/bug.php?id=31347
>

The patch originates in Debian, and I can assure you that they don't build
for Windows (:
So that's a good point, thanks.

We could probably test for ZEND_WIN32, or at least that's what I see at
ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd
support (commit f90483001236c863abe1070d05ee2214db5a0a97).

If that sounds OK, I'll try to do the change (although I'm not a developer).

Kaplan

--001a11c30920a926e204e771ce7d--