Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69394 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57111 invoked from network); 27 Sep 2013 13:02:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Sep 2013 13:02:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:60237] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7B/E2-42235-0D185425 for ; Fri, 27 Sep 2013 09:02:09 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 81F3EE202D; Fri, 27 Sep 2013 14:02:05 +0100 (BST) Date: Fri, 27 Sep 2013 14:02:05 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Lior Kaplan cc: PHP internals list In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Gnu/Hurd support From: derick@php.net (Derick Rethans) On Thu, 26 Sep 2013, Lior Kaplan wrote: > Hi, > > In Debian we build PHP for GNU/Hurd system, which need some minor fixes > available here: > > http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/116-posixness_fix.patch 46 --- php5.orig/main/php.h 47 +++ php5/main/php.h 48 @@ -244,6 +244,10 @@ END_EXTERN_C() 49 /* macros */ 50 #define STR_PRINT(str) ((str)?(str):"") 51 52 +#ifndef PATH_MAX 53 +#define PATH_MAX 4096 54 +#endif 55 + 56 #ifndef MAXPATHLEN 57 # ifdef PATH_MAX 58 # define MAXPATHLEN PATH_MAX That looks wrong. You're unconditionally defining PATH_MAX, but there is logic in line 57 that deals with this too... cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug Posted with an email client that doesn't mangle email: alpine