Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:69373 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94261 invoked from network); 27 Sep 2013 02:37:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Sep 2013 02:37:18 -0000 Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.216.169 mail-qc0-f169.google.com Received: from [209.85.216.169] ([209.85.216.169:53813] helo=mail-qc0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 15/00-28456-C5FE4425 for ; Thu, 26 Sep 2013 22:37:16 -0400 Received: by mail-qc0-f169.google.com with SMTP id c9so1384958qcz.28 for ; Thu, 26 Sep 2013 19:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=ix+wqpAtUhPvNQp/LjifdqbbS/VlQrQ4u3/5cNYG6fM=; b=FYWLtZJHU5kMvD8Sf1M3MbX5AACFWHy/hE0VJ37kvNRDVAHKsSz+u+efMcqmZmtCL2 NW/xAWQvjXqVBh8vvKRgwN26eEDyaJbhWWXyQ2qjiayAhw/3Vn9dGa11mJRk577Qx6n8 cGsUN59Z9JNXczAw+dDEUHiB4MsAq3RBOogNfsD4qxm5MWp/KH1pWGUpiaoHoEnuZ5cS P3/EpoUX4zuzPl1XYqRD2db3jCFQb3XaVjgqF9eQcSWiELcip1ar1mZvRqvhJxyXpeZ4 DenkuY0Y5jPlO5e5fYqpfT3OR4j7ErVRarT8mk5FRLc08YsXdtpNbgDFPsNGKlREWn5B 0kzg== MIME-Version: 1.0 X-Received: by 10.224.14.82 with SMTP id f18mr10741148qaa.58.1380249433931; Thu, 26 Sep 2013 19:37:13 -0700 (PDT) Received: by 10.49.61.227 with HTTP; Thu, 26 Sep 2013 19:37:13 -0700 (PDT) Date: Fri, 27 Sep 2013 10:37:13 +0800 Message-ID: To: PHP Internals Content-Type: multipart/alternative; boundary=047d7bdc80f836042104e7545d92 Subject: Failing builds on Travis From: tjerk.meesters@gmail.com (Tjerk Meesters) --047d7bdc80f836042104e7545d92 Content-Type: text/plain; charset=ISO-8859-1 Hi, The success of builds on Travis seems to hinge on a particular test case: ext/standard/tests/file/disk_free_space_basic.phpt It asserts that if a file is written to, the free space after the write must always be lower than the previously recorded value. On a busy system the free space is affected by many factors that can cause this assertion to fail and thus developers get a nasty looking (X) on their pull requests. Can't we just assert that "the function returns a float, hurray!" instead? -- -- Tjerk --047d7bdc80f836042104e7545d92--