Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69370
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAFMT4Npvz8+PrSZQx=P375TSQLsCX7L=a3iYm6Kz_7rSLOiiJA@mail.gmail.com>
References: <CAGa2bXaf0MefCj6s_MEbJmnSk8G+hvm5CMNyH_ODeRhSub5LRg@mail.gmail.com>
 <CAPwsocFgv2dNGo7+5KxayrSinvm8aieKvj-WcT21ACAPLMCBrg@mail.gmail.com>
 <CAGa2bXbptncHo5vNwuySvhj8hPLFg14u4jVu8tDptVKfN7S=3A@mail.gmail.com>
 <CAFMT4NrxFciCZL4ENdSCqRW3cYyWWKQFWMJRM+95FBkDXPaPkg@mail.gmail.com>
 <522B4F8D.2040107@mjburgess.co.uk> <op.w21u24l6c9evq2@nikita-pc> <CAFMT4Npvz8+PrSZQx=P375TSQLsCX7L=a3iYm6Kz_7rSLOiiJA@mail.gmail.com>
Date: Fri, 27 Sep 2013 09:59:19 +0900
Message-ID: <CAGa2bXa1r4QmJqOW0zY1nkM2=F7y192mtPgKY5p3xrufwD740Q@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Nikita Nefedov <inefedor@gmail.com>, internals <internals@lists.php.net>, 
	Michael John Burgess <michael@mjburgess.co.uk>
Content-Type: multipart/alternative; boundary=001a11c3fe90750fd904e7530125
Subject: Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c3fe90750fd904e7530125
Content-Type: text/plain; charset=UTF-8

Hi,

On Sun, Sep 8, 2013 at 1:43 AM, Levi Morrison <morrison.levi@gmail.com>wrote:

> You have a flawed understanding of good functional design. Instead of
> directly calling the escaping function you would simply ask for a callable
> and pass in the escaping function. Thus, you could use an alternative
> escaping function at runtime.
>
> The methods route is a poor choice. If we use classes at all, separate the
> responsibility of each type of escaping to a separate class. Escaping JSON
> and HTML code have little (possibly nothing) in common and do not belong in
> the same class.
>

You are proposing something like

$escape_function = function($input) {
    $output=avaScriptEscaper->escape($input);
     $output=do_some_additional($output);
     return $output;
}

my_escape($some_data, $escape_function) {
    return $escape_function($some_data);
}

Is this correct?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c3fe90750fd904e7530125--