Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69341
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <13848974-B5E7-4044-9F04-C4EB15E09E9C@gmail.com>
References: <CAL+t6cEMqyvV5EwWipOACouJiTwzyWzVvnce7WoMRetQNe+OAA@mail.gmail.com>
	<CAFMT4Nqg-spRjHGde4vDBRUM1wa2zUVC9SrBzeQURMQBSW6vQA@mail.gmail.com>
	<CAL+t6cHuUEbQMYsaYnYvGtP5O1Y5OU6niZN4nHjumEGB6VLU-w@mail.gmail.com>
	<CAHMUw2EdVKpHA10mbR=AR2GAOcA2=fBVbhyRskswOf=ZVC64gQ@mail.gmail.com>
	<CAL+t6cGR03xBUFRZK6Foixa6gx3Kj24_HiQxFAs4Seka-s70aw@mail.gmail.com>
	<CAJ26g5TMDtyN+UN6g2V83hcduTet58SYtavtq5TmtcqyK5XACg@mail.gmail.com>
	<13848974-B5E7-4044-9F04-C4EB15E09E9C@gmail.com>
Date: Thu, 26 Sep 2013 12:42:01 +0800
Message-ID: <CAHMUw2EWyiQT2hWkhb77gt5SpTZtih-=u0PrNs170TG78=+24g@mail.gmail.com>
To: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2c54cab6b5c04e741fd66
Subject: Re: [PHP-DEV] PR 287 - added use_keys argument to array_filter() [Discussion]
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--001a11c2c54cab6b5c04e741fd66
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I've updated my patch to allow a range of values to be passed as the third
argument: pass key, pass value or pass both.

Instead of using OR-able constants, I went with an enumeration type because
there are only going to be three options; it just felt wrong to have
`ARRAY_FILTER_USE_KEY | ARRAY_FILTER_USE_VALUE` instead of a simpler
`ARRAY_FILTER_USE_BOTH` or even just `true`.

Updated examples can be found here: https://github.com/php/php-src/pull/287

Let me know if there are any major objections to the patch.



On Wed, Jun 19, 2013 at 7:15 AM, Tjerk Meesters <tjerk.meesters@gmail.com>wrote:

>
>
> On 19 Jun, 2013, at 1:04 AM, Patrick Schaaf <bof@bof.de> wrote:
>
>
> > var_dump(array_filter(['foo', '', 'bar'], 'strlen', true));
> >
> > Warning: strlen() expects exactly 1 parameter, 2 given in - on line 1
> >
> > Not only do we trigger the error handler (a large enough array causes a
> > performance issue), but we also get back an empty array as a result.
> That's
> > BC and performance loss that's simply unacceptable, so defaulting the
> > behavior to pass the key is simply out of the question.
>
> Existing code won't pass that third, true, argument to array_filter(), and
> thus will not break.
>
> Nevertheless, I'd say go with a new array_filter_key() function, because
> that permits using existing one-parameter functions like that strlen as a
> callback, instead of forcing two-parameter callback functions.
>
> I've mirrored the behaviour of this feature from JavaScript as much as
> possible (but obviously without passing the array itself as the third
> argument). As such I don't feel there's a need to introduce yet another
> function just so that the key is passed as the first argument. And to use
> both key and value forces the developer to use closures instead of just any
> callback unless this means the second argument passed to the callback is
> the array :)
>
> Another alternative might be to go with a third argument to
> array_filter(), but make that an integer with ORable constants
> ARRAY_FILTER_KEY, ARRAY_FILTER_VAL - only one of them set calls with a
> single argument, both set call with two arguments.
>
> I see some potential here, albeit a bit more magical :) Let's see how the
> discussion progresses.
>
> best regards
>   Patrick
>
> --
> --
> Tjerk
>

--001a11c2c54cab6b5c04e741fd66--