Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69337
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: internals@lists.php.net,Terence Copestake <terence.copestake@gmail.com>
Message-ID: <5242E88D.90407@php.net>
Date: Wed, 25 Sep 2013 14:43:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
References: <D9.10.12097.032EF325@pb1.pair.com> <alpine.DEB.2.10.1309230946590.5168@whisky.home.derickrethans.nl> <CAMyk_AaEZRqMwFXKhHyHn4PvxhPdCqwP1Cn8vmnoajW38ZSE5A@mail.gmail.com> <slrnl42thm.a07.dsp@dsp.local> <CAPMc8uaFVTUwEEWw49AgvOJxK8i-6SFdFq-RxFpbo__TRtZiWA@mail.gmail.com> <CAF9U7z85iJsHppjpjUNZ3TT=Oq17_FHoXzE-Xv8BwczWXjK6cw@mail.gmail.com> <5241F11C.5080707@php.net> <008301ceb967$b49ab190$1dd014b0$@tutteli.ch> <524205D8.8000608@php.net> <CAPMc8uYwwd9s2SN4uVWRf7QuFZRxAmoeDpNsSc16funCOe13Vg@mail.gmail.com> <5242ADAE.2080007@php.net> <CAPMc8uaNXj4TC6wDh7OZWhF60QRO-fd1JccyK8CZffcMjrLrKQ@mail.gmail.com>
In-Reply-To: <CAPMc8uaNXj4TC6wDh7OZWhF60QRO-fd1JccyK8CZffcMjrLrKQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: Anonymous Classes
From: krakjoe@php.net (Joe Watkins)

On 09/25/2013 02:02 PM, Terence Copestake wrote:
>> 1) Anonymous classes in PHP would support a constructor, so I don't see
>> the need for use to be utilized here, it would just clutter declarations
>> and the patch.
>
>
> This works, but it's more effort for the programmer and arguably just
> moving the "clutter" from the declaration to the constructor.
>
> e.g.
>
> (new class ...
>      protected $value;
>      public function __construct($value)
>      {
>          $this->value = $value;
>      }
>
>      public function doSomething()
>      {
>          echo $this->value;
>      })($val)
>
> vs.
>
> (new class ...
>      public function doSomething() use ($val)
>      {
>          echo $val;
>      })
>
> It gets even uglier for passing by reference.
>
>
>> 2) Again, constructors can be used, and is less confusing than introducing
>> a new variable, but I'm open to persuasion if the idea is liked in general
>> ...
>
>
> This is fine when working with only a handful of values, but what about
> needing access to a large number of values? What about making (especially
> protected) method calls within the anon class?
>
> Along the same vein, why did we even bother having "use" and $this for
> closures, if you can after all just pass everything as arguments?
>
> If there are realistic and elegant alternative solutions to the problems
> presented, that's fair enough. Rejecting something because it's not as
> simple to implement and you can hack around it in user code anyway...
> that's a dangerous way to go about your business.
>

The first example doesn't make good sense:

 > (new class ...
 >      protected $value;
 >      public function __construct($value)
 >      {
 >          $this->value = $value;
 >      }
 >
 >      public function doSomething()
 >      {
 >          echo $this->value;
 >      })($val)

If $value is protected then how are you passing it in from outside as $val ?

If your anonymous class needs access to protected methods (which in turn 
might want to read private members) then there's already an established 
way of declaring that:

<?php
class Outer {
     private $dice;

     public function __construct($dice) {
         $this->dice = $dice;
     }

     protected function protectedMethod() {
         return $this->dice;
     }

     public function publicMethod() {
         return new class extends Outer {
             public function forwardToProtectedMethod() {
                 $this->protectedMethod();
             }
         }($this);
     }
}
var_dump((new Outer($_SERVER))->publicMethod());
?>

This works now, as you expect it too ... not elegant enough ?? you don't 
think use() everywhere might be a little bit much ??

Lets try to keep it as simple as possible, I think ...

Cheers