Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69189
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52399abd.070a0e0a.1dad.5877SMTPIN_ADDED_BROKEN@mx.google.com>
References: <CAPwsocGni4kjJq9c5wr77ohPU+YX2=0O7EgahdH=p0=hH1H_fA@mail.gmail.com>
	<52399abd.070a0e0a.1dad.5877SMTPIN_ADDED_BROKEN@mx.google.com>
Date: Wed, 18 Sep 2013 13:57:42 +0100
Message-ID: <CAPwsocFb3wLfxSsuKWdo6YHijGjakSDkN9yrdTb2d2d5wfx+kg@mail.gmail.com>
To: Frank Liepert <Frank.Liepert@gmx.de>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Allowing is_* functions to accept multiple parameters
From: leight@gmail.com (Leigh)

On 18 September 2013 12:15, Igor Wiedler <igor@wiedler.ch> wrote:
>
> for is_* functions, this could easily be done with a higher-order "every" function. You pass a predicate and an array of values. It returns a boolean.
>
> Example:
>
>         if (!every('is_int', $numbers)) {
>                 throw new \InvalidArgumentException(...);
>         }
>
> Not only is that much cleaner in my opinion, it also is composable without having to change *all* of the is_* predicates.

Might just be me, but I don't really like having function names as
strings (obviously I use it when I _have_ to, but I try and stay away
from it otherwise).

Feedback I'm really interested in is what issues could arise from
changing those predicates. I'm pretty short sighted in this regard,
and mainly see the benefits I would gain from this change, so looking
for more "This is a terrible idea because..." kind of stuff.


On 18 September 2013 13:21, Frank Liepert <Frank.Liepert@gmx.de> wrote:
>
> Returning bool in this case will make it impossible to respond with a
> meaningful error message. Which of the provided arguments !is_int()?

I agree that it doesn't fit every case, and it's not supposed to. The
same can be said of isset(), if it is important to know which argument
was not set, then you have to use multiple calls.


On 18 September 2013 13:21, Frank Liepert <Frank.Liepert@gmx.de> wrote:
>
> Finally, the imho best solution would still be introducing optional scalar
> type hinting. But that is another topic and shouldn't be discussed here.

I agree, (both that it would be better, and that it is another topic
entirely - one which usually goes in circles, so lets stay away from
it here :))