Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69188
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.52 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
References: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
Date: Wed, 18 Sep 2013 14:56:04 +0200
Message-ID: <CAMUwpuQxUo6Rt+OHfrrOVc=ffe8JhX_Zsa3uqz9+CG08+e+tsQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bacb98e326fc204e6a7f8f5
Subject: Re: [PHP-DEV] Signature compatibility: Number of arguments
From: jpauli@php.net (Julien Pauli)

--047d7bacb98e326fc204e6a7f8f5
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Aug 29, 2013 at 11:33 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> This is a spinoff from the variadics thread. Quoting Stas:
>
> > I also think this:
> >     public function query($query, ...$params)
> >     public function query(...$params)
> > should be legal too.
>
> This is a general issue in PHP that we might want to fix: Currently a
> method A is not compatible with a method B if A has less arguments than B.
>
> E.g. both of the following are incompatible signatures:
>
>     public function foo($bar)
>     public function foo()
>
>     public function foo($bar = NULL)
>     public function foo()
>

I dont really agree.

One could use reflection on the parameter, thus expecting it to be here on
a child instance :

class Foo
{
    public function bar($arg = null)  {  }
}

class Foo2 extends Foo
{
    public function bar()  {  }
}

$o = new Foo; /* Switching to Foo2 will lead to an Exception */
$r = new ReflectionParameter(array($o, 'bar'), 'arg');
echo $r->getName();


PS : I remember having a long discussion with Gustavo, some time ago, about
LSP in PHP ; and we could not agree on some points, particularly concerning
optional parameters.

Julien.Pauli

--047d7bacb98e326fc204e6a7f8f5--