Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69182
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
References: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
Date: Wed, 18 Sep 2013 12:30:01 +0200
Message-ID: <CAF+90c8VPsJ+7Bn4OTAm+F1O69rMW3MrF_WZzYhuA=rAPSyvBg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0149c3c074b29904e6a5eb90
Subject: Re: Signature compatibility: Number of arguments
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0149c3c074b29904e6a5eb90
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Aug 29, 2013 at 11:33 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> This is a spinoff from the variadics thread. Quoting Stas:
>
> > I also think this:
> >     public function query($query, ...$params)
> >     public function query(...$params)
> > should be legal too.
>
> This is a general issue in PHP that we might want to fix: Currently a
> method A is not compatible with a method B if A has less arguments than B.
>
> E.g. both of the following are incompatible signatures:
>
>     public function foo($bar)
>     public function foo()
>
>     public function foo($bar = NULL)
>     public function foo()
>
> This doesn't really make sense. Removing parameters doesn't violate LSP,
> because in PHP it is legal to pass more arguments than declared. (Only
> adding additional required parameters would violate LSP.)
>
> Is it okay to change this?
>
> Thanks,
> Nikita
>

Considering that we might support named parameters in the future I'm
withdrawing this suggestion. This allows removing a parameter name, which
would cause problems in that context.

Nikita

--089e0149c3c074b29904e6a5eb90--