Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:69098
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.111.112 as permitted sender)
Message-ID: <BLU0-SMTP103D90EDFF5DEEA5D5FA3DFE23A0@phx.gbl>
Content-Type: text/plain; charset="windows-1252"
MIME-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
In-Reply-To: <CALJZF3hf+xeep+hxEzF+FZuxeEZH6jS0ac=ixzxyYWCiZzWhEw@mail.gmail.com>
Date: Thu, 12 Sep 2013 16:34:40 +0200
CC: Developers List PHP Mailing <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
References: <BLU0-SMTP120B69BA7C5BC348F5D05DDE2390@phx.gbl> <CALJZF3j9t1PbEz6bQ1nUazeJz4vQpowsCH6av-P811cbKMiW8A@mail.gmail.com> <BLU0-SMTP18538E81AEA566D2D3C4590E23A0@phx.gbl> <CALJZF3hf+xeep+hxEzF+FZuxeEZH6jS0ac=ixzxyYWCiZzWhEw@mail.gmail.com>
To: Michael Wallner <mike@php.net>,
 Benjamin Eberlei <kontakt@beberlei.de>
Subject: Re: [PHP-DEV] Support for keywords where possible
From: bobwei9@hotmail.com (Bob Weinand)

Am 12.9.2013 um 15:06 schrieb Michael Wallner <mike@php.net>:
> On 12 September 2013 14:56, Bob Weinand <bobwei9@hotmail.com> wrote:
>> A little benchmark here: https://gist.github.com/bwoebi/6536824
>>=20
>> Here I picked always the best from 10 times running.
>>=20
>> With patch:
>> root# ./sapi/cli/php microbench.php
>> Took for 10000 iterations: 8.6687519550323 seconds
>>=20
>> Without patch:
>> root# ./sapi/cli/php ../bwo-php-src/microbench.php
>> Took for 10000 iterations: 8.5741410255432 seconds
>>=20
>> But this is the very worst case. (e.g. there are JUST cases where =
strncasecmp needs to be used)
>=20
> Is there a number missing after "JUST"?

no=85 I mean, in the benchmark are included all the cases where =
strncasecmp needs to be used.

>> When picking random files the results are pretty similar:
>=20
> What random files?

Some PHP files that were on my server

>>=20
>> With patch:
>> root# ./sapi/cli/php microbench.php
>> Took for 10000 iterations: 15.564201116562 seconds
>>=20
>> Without patch:
>> root# ./sapi/cli/php microbench.php
>> Took for 10000 iterations: 15.562065023422 seconds
>>=20
>> It's here only a difference of about 2 milliseconds or 0,01% what is =
in the margin of error I think.
>=20
> I'd love to have the freedom your patch provides, but I'm not =
convinced yet :)
> How does it affect running one of the major frameworks out there?
>=20
>=20
> --=20
> Regards,
> Mike


As Benjamin suggested, here the best running times of "time phpunit" in =
the symfony test suite:

With patch:
real 0m30.885s
user 0m14.713s
sys 0m2.123s

Without patch:
real 0m31.380s
user 0m14.865s
sys 0m2.170s

Seems that it is very similar (I have here variances of =B12 seconds=85) =
So I think my patch doesn't have a huge impact.

Bob Weinand=