Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68952
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 48412 invoked from network); 7 Sep 2013 17:35:37 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 7 Sep 2013 17:35:37 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net  
Received: from [217.114.215.10] ([217.114.215.10:50468] helo=mail.experimentalworks.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A8/CD-00660-7E36B225 for <internals@lists.php.net>; Sat, 07 Sep 2013 13:35:36 -0400
Received: from [192.168.2.20] (ppp-88-217-85-151.dynamic.mnet-online.de [88.217.85.151])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: johannes@schlueters.de)
	by mail.experimentalworks.net (Postfix) with ESMTPSA id 74E8B3FE2F;
	Sat,  7 Sep 2013 19:35:36 +0200 (CEST)
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: chobie <chobieee@gmail.com>, PHP internals <internals@lists.php.net>
In-Reply-To: <CAF+90c9NXqPbp0L-MnbvcAmxVmPN-co1WWef21UQ=emXcuHseg@mail.gmail.com>
References:
	 <CAGfRu7Pq9DTdiVwp-mo8LvZVf_JuykeQmLKOkhMXVStc7FT70g@mail.gmail.com>
	 <CAF+90c9NXqPbp0L-MnbvcAmxVmPN-co1WWef21UQ=emXcuHseg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 07 Sep 2013 19:35:20 +0200
Message-ID: <1378575320.4432.2.camel@guybrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] adding class entry getter for JsonSerializeable
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Sat, 2013-09-07 at 17:46 +0200, Nikita Popov wrote:
> The code has an "extern zend_class_entry *php_json_serializable_ce;" right
> above that line. Shouldn't that be enough?

that only affects code in the same linker run (executable binary or .so)
as weak the linker to hide symbols. For stuff that should work in other
extensions one has to mark them as ZEND_API in the engine or PHPAPI in
core stuff, or a custom EXTENSIONNAME_API (see different
ext/foo/php_foo.h headers)

johannes