Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68949 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42239 invoked from network); 7 Sep 2013 16:46:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Sep 2013 16:46:37 -0000 Authentication-Results: pb1.pair.com header.from=chobieee@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=chobieee@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.45 as permitted sender) X-PHP-List-Original-Sender: chobieee@gmail.com X-Host-Fingerprint: 209.85.160.45 mail-pb0-f45.google.com Received: from [209.85.160.45] ([209.85.160.45:45899] helo=mail-pb0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E0/9C-00660-C685B225 for ; Sat, 07 Sep 2013 12:46:36 -0400 Received: by mail-pb0-f45.google.com with SMTP id mc17so4441655pbc.18 for ; Sat, 07 Sep 2013 09:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=6rVh3VGhPTqFA/gjYT+htLzfjL9W2uhHHFRp2VK9EkQ=; b=zYDv/jxZGrxaSeqlNIB0HeUkT3KKw8Anp0bg1cA6e39Iyr18QZA7CHM0wxtLqoMiT/ 2+CReoZ6ppmBxVl7imhuvtwAPn2S5nIiNL46k58HH/UbfhcpLTTFIA3+C4i++KMAVlnu avjcA/65htdBhtFMCDIdc5AwM9qqQHBNYIF+bhBpc4ed8cXIw4BLYHeXhJjtY0RRw1Su c9NfsLx0mygjHH5M28xY7tEcVu4nfStYa6EousMd5G+DPf5ZWnMGi82jb0cO4S3UJ//j CgEKYkmbC3OH3qA+OPkNNoqURyen6fRRlPby+i6b85IvPBy7dbzbsp2Ch1te4cY2Gduj CU7w== MIME-Version: 1.0 X-Received: by 10.66.122.100 with SMTP id lr4mr2295067pab.164.1378572393887; Sat, 07 Sep 2013 09:46:33 -0700 (PDT) Received: by 10.68.28.10 with HTTP; Sat, 7 Sep 2013 09:46:33 -0700 (PDT) In-Reply-To: References: Date: Sun, 8 Sep 2013 01:46:33 +0900 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary=047d7b2e0de7d5bdd004e5cde5f1 Subject: Re: [PHP-DEV] adding class entry getter for JsonSerializeable From: chobieee@gmail.com (chobie) --047d7b2e0de7d5bdd004e5cde5f1 Content-Type: text/plain; charset=ISO-8859-1 Yea, but my php binary doesn't export php_json_serializable_ce. Did I missed something? nm /Users/chobie/.phpenv/versions/5.5-zts-debug/bin/php | grep php_json_serializable_ce 0000000100c00460 s _php_json_serializable_ce 2013/9/8 Nikita Popov > On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote: > >> Hi internals, >> >> I realized we could not retrieve php_json_serializable_ce from other >> extension module. JsonSerializeable interface is easy to serialize with >> `json_encode`. So I want to adding getter function. >> >> The patch can be found here: >> >> https://github.com/chobie/php-src/compare/adding-jsonserializeable-ce-getter >> >> I want to have feedback on the idea. >> > > The code has an "extern zend_class_entry *php_json_serializable_ce;" right > above that line. Shouldn't that be enough? > > Nikita > > --047d7b2e0de7d5bdd004e5cde5f1--