Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68946
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.169 as permitted sender)
Content-Type: text/plain; charset=koi8-r; format=flowed; delsp=yes
To: internals@lists.php.net, "Michael John Burgess" <michael@mjburgess.co.uk>
References: <CAGa2bXaf0MefCj6s_MEbJmnSk8G+hvm5CMNyH_ODeRhSub5LRg@mail.gmail.com> <CAPwsocFgv2dNGo7+5KxayrSinvm8aieKvj-WcT21ACAPLMCBrg@mail.gmail.com> <CAGa2bXbptncHo5vNwuySvhj8hPLFg14u4jVu8tDptVKfN7S=3A@mail.gmail.com> <CAFMT4NrxFciCZL4ENdSCqRW3cYyWWKQFWMJRM+95FBkDXPaPkg@mail.gmail.com> <522B4F8D.2040107@mjburgess.co.uk>
Date: Sat, 07 Sep 2013 20:36:30 +0400
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-ID: <op.w21u24l6c9evq2@nikita-pc>
In-Reply-To: <522B4F8D.2040107@mjburgess.co.uk>
User-Agent: Opera Mail/12.16 (Win32)
Subject: Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?
From: inefedor@gmail.com ("Nikita Nefedov")

On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess  
<michael@mjburgess.co.uk> wrote:

> On 07/09/2013 15:41, Levi Morrison wrote:
>>> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
>>>
>>> Any comments?
>>
>>
>> Please, don't go down this route. You do not want one class to escape  
>> all
>> kinds of data; delegate each type of escaping to its own class:
>>
>> JavaScriptEscaper->escape();
>> PhpEscaper->escape();
>> HtmlEscaper->escape();
>> HtmlAttributeEscaper->escape();
>>
>> I should not have to defend this but I am willing to explain in more  
>> detail
>> if someone would like me to.
>>
>
>
> There doesnt need to be any object-oriented version for this problem.  
> It's a series of pure functions. Wraping them in one or more classes  
> adds nothing.
>
> Michael
>

Hi,

Wrapping those functions in methods means they can be extended in child  
classes. So suppose you have some library that takes object of type  
Spl_Escaper and uses its methods for escaping some data. Now if you will  
need some additional escaping you just need to make child class for  
Spl_Escaper and override methods which behavior you need to change. This  
can't be done with pure functions (in PHP).