Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68944 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26428 invoked from network); 7 Sep 2013 15:46:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Sep 2013 15:46:12 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.46 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.212.46 mail-vb0-f46.google.com Received: from [209.85.212.46] ([209.85.212.46:48390] helo=mail-vb0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 72/29-00660-34A4B225 for ; Sat, 07 Sep 2013 11:46:11 -0400 Received: by mail-vb0-f46.google.com with SMTP id p13so2933926vbe.33 for ; Sat, 07 Sep 2013 08:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=A1efL/2xHVyy9ISwYzp9MwbBVk2uAPghIUM2yhQOfpY=; b=zAz0IRs6tQXRXVz7mnS2RgyCJr519gs19Q8TJMxLonH4TowI+2Xx/by0OhpU55O0/J 6qzm5eJt8+y4kdUuQHAOcy/tRlNHLE4AgL+W5gZmNkTn1YqOqZQXe3AKNmej0j3/RXA0 MYT/BhL4qmRn6TAGTrKhJgiLzNnembtlzXq85OURUbvQxI3Tf7LKtzVDlsQQKOoN0NZP tPdPB8bjpT1Q40D81awwC69tCtCyR2YHzGkqszI23LFuS6VYHQ5GQWJOHxF1KLeZISJ4 wLmCCV/WwSTn0ch6Nlk0wFwnRQQ2oReVKgol8+NVr+5mnXl+9/eCVpYKqYVZWuleQJox wF4g== MIME-Version: 1.0 X-Received: by 10.220.105.199 with SMTP id u7mr7892767vco.1.1378568768609; Sat, 07 Sep 2013 08:46:08 -0700 (PDT) Received: by 10.220.17.136 with HTTP; Sat, 7 Sep 2013 08:46:08 -0700 (PDT) In-Reply-To: References: Date: Sat, 7 Sep 2013 17:46:08 +0200 Message-ID: To: chobie Cc: PHP internals Content-Type: multipart/alternative; boundary=047d7b343ecac0655504e5cd0d84 Subject: Re: [PHP-DEV] adding class entry getter for JsonSerializeable From: nikita.ppv@gmail.com (Nikita Popov) --047d7b343ecac0655504e5cd0d84 Content-Type: text/plain; charset=ISO-8859-1 On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote: > Hi internals, > > I realized we could not retrieve php_json_serializable_ce from other > extension module. JsonSerializeable interface is easy to serialize with > `json_encode`. So I want to adding getter function. > > The patch can be found here: > > https://github.com/chobie/php-src/compare/adding-jsonserializeable-ce-getter > > I want to have feedback on the idea. > The code has an "extern zend_class_entry *php_json_serializable_ce;" right above that line. Shouldn't that be enough? Nikita --047d7b343ecac0655504e5cd0d84--