Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68942
Return-Path: <morrison.levi@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 19039 invoked from network); 7 Sep 2013 14:41:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 7 Sep 2013 14:41:42 -0000
Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.42 as permitted sender)
X-PHP-List-Original-Sender: morrison.levi@gmail.com
X-Host-Fingerprint: 209.85.219.42 mail-oa0-f42.google.com  
Received: from [209.85.219.42] ([209.85.219.42:32844] helo=mail-oa0-f42.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E9/A7-00660-52B3B225 for <internals@lists.php.net>; Sat, 07 Sep 2013 10:41:42 -0400
Received: by mail-oa0-f42.google.com with SMTP id n12so5172927oag.29
        for <internals@lists.php.net>; Sat, 07 Sep 2013 07:41:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=3fYepUHsjvhghopiVvQTCdkjvcdKOMW3OQhY+DsxkWk=;
        b=A0sKGGcLRR3p5YGeoJXtAUvPWgeydmYX1XIlzgDvirRE8qEbVmavSgSIFB76qVZBhc
         fl05E6IlolMXAW/qYugSy4+O73fByaDXA3EHgkT6mV8O2v12BigkEteInZqsGwHEITlQ
         fkDMovIPP8Up2yyQ8KS56qrtCeHnoFTjwGjvqF+o9ItZsQHVS84wMnFNKqlpWZehUSHz
         CcTEQGtRvNXAPp3szAX9BIYSxYKY7tFouDmNNFr0NfIniKrCkXiAYw49kq26l3DgX/pY
         tp14mHocltKe4/AE/IdCGTRHPryUroYcTENEUzLFTU0xqxBd5FVglDHWCchg5luTJWJO
         kOsw==
MIME-Version: 1.0
X-Received: by 10.182.213.97 with SMTP id nr1mr5496136obc.48.1378564898977;
 Sat, 07 Sep 2013 07:41:38 -0700 (PDT)
Received: by 10.76.122.200 with HTTP; Sat, 7 Sep 2013 07:41:38 -0700 (PDT)
In-Reply-To: <CAGa2bXbptncHo5vNwuySvhj8hPLFg14u4jVu8tDptVKfN7S=3A@mail.gmail.com>
References: <CAGa2bXaf0MefCj6s_MEbJmnSk8G+hvm5CMNyH_ODeRhSub5LRg@mail.gmail.com>
	<CAPwsocFgv2dNGo7+5KxayrSinvm8aieKvj-WcT21ACAPLMCBrg@mail.gmail.com>
	<CAGa2bXbptncHo5vNwuySvhj8hPLFg14u4jVu8tDptVKfN7S=3A@mail.gmail.com>
Date: Sat, 7 Sep 2013 08:41:38 -0600
Message-ID: <CAFMT4NrxFciCZL4ENdSCqRW3cYyWWKQFWMJRM+95FBkDXPaPkg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Leigh <leight@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c20afc1a7e5604e5cc2737
Subject: Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?
From: morrison.levi@gmail.com (Levi Morrison)

--001a11c20afc1a7e5604e5cc2737
Content-Type: text/plain; charset=ISO-8859-1

> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
>
> Any comments?


Please, don't go down this route. You do not want one class to escape all
kinds of data; delegate each type of escaping to its own class:

JavaScriptEscaper->escape();
PhpEscaper->escape();
HtmlEscaper->escape();
HtmlAttributeEscaper->escape();

I should not have to defend this but I am willing to explain in more detail
if someone would like me to.

--001a11c20afc1a7e5604e5cc2737--