Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68938
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c85v_VTPTPanBcTJ70Ff6pm6fRgAGs4n1uoaA+B9UZg=w@mail.gmail.com>
References: <CAF+90c85v_VTPTPanBcTJ70Ff6pm6fRgAGs4n1uoaA+B9UZg=w@mail.gmail.com>
Date: Sat, 7 Sep 2013 09:52:08 +0200
Message-ID: <CAEZPtU47VVdGscUBUbcnh6PAQDfP1FtpgnDHJ1=RrFoMCgQ0Sw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Named parameters
From: pierre.php@gmail.com (Pierre Joye)

hi!

On Fri, Sep 6, 2013 at 6:39 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> Hi internals!
>
> I created an RFC and preliminary implementation for named parameters:
>
>     https://wiki.php.net/rfc/named_params
>
> The RFC and implementation are not yet complete. I mainly want to have
> feedback on the idea in general and on the Open Questions (
> https://wiki.php.net/rfc/named_params#open_questions) in particular.

Love it and always wanted it! Thanks for working on that!

I quickly look at the patch and related phpt, so feel free to nicely
correct me if I ask something already covered :)

In no particular order:

. Warning: Cannot pass positional arguments after named arguments.
Aborting argument unpacking in %s on line %d

Would it make more sense to make it a fatal error? As the code will
likely not work as expected, at all. It could be a bit too harsh but
as it is a new feature, there is no BC impact and ensure good usage.

. would it make sense to have an alternative zend API to fetch one or
more argument using its name? I can see a couple of usages for such a
function

- It would be nice to add (later once the RFC is more stable) docs
about which impacts and changes are expected for extension developers

- Do you have a fork for this RFC? Much easier to test, create snaps, etc.



Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org