Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68837
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52243BA6.5040905@sugarcrm.com>
References: <52243BA6.5040905@sugarcrm.com>
Date: Mon, 2 Sep 2013 11:20:27 +0200
Message-ID: <CAF+90c9SDjXC1EjHPDaQjEhvcrtt_=_28r18O43NSLrX9tW4og@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0111bcfa3deb8804e563157f
Subject: Re: [PHP-DEV] [RFC] Skipping parameters take 2
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0111bcfa3deb8804e563157f
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Sep 2, 2013 at 9:17 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> I've finally took some time to revive the skipping parameter RFC and
> patch. For those who doesn't remember what it is please see:
> https://wiki.php.net/rfc/skipparams
> TLDR version:
>
> The idea is to allow skipping parameters in function with optional
> arguments so that this:
>    function create_query($where, $order_by, $join_type='INNER', $execute
> = false, $report_errors = true)
>
> can be called like this:
>     create_query("deleted=0", "name", default, default,
> /*report_errors*/ true);
>
> Instead of trying to remember what the defaults are.
> The patch is here:
>
> https://github.com/php/php-src/pull/426
>
> Any comments or feedback on the RFCs and the code are welcome,
> especially pointing out the cases where it may not work (which means we
> need more phpt's there :)
>

I'm -1 on this proposal.

I think this doesn't really help readability. Right now you should
implement functions with many options with an $options array.

If we want to change something here, we should skip this step and go right
for named arguments. I think I'll give implementing them a try.

Nikita

--089e0111bcfa3deb8804e563157f--