Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68779
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
Message-ID: <522209BE.9070405@gmail.com>
Date: Sat, 31 Aug 2013 16:20:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8
MIME-Version: 1.0
To: Nikita Popov <nikita.ppv@gmail.com>
CC: PHP internals <internals@lists.php.net>
References: <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com> <CAF+90c8pnaj1s_tsYDZz5G3G6uD2J0CNdRh1yhB_TWSNhZgxdw@mail.gmail.com> <CAF+90c818TJO1Z1hq8AUz2AbxLJbHhovHR0S8jkP1LjCu+W3kA@mail.gmail.com>
In-Reply-To: <CAF+90c818TJO1Z1hq8AUz2AbxLJbHhovHR0S8jkP1LjCu+W3kA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Always set return_value_ptr?
From: ellison.terry@gmail.com (Terry Ellison)

On 31/08/13 14:13, Nikita Popov wrote:
>>> Is there any particular reason why we only pass return_value_ptr to internal functions if they have the ACC_RETURN_REFERENCE flag set?
>>>
>>> Why can't we always provide the retval ptr, even for functions that don't return by reference? This would allow returning zvals without having to copy them first (what RETVAL_ZVAL does).
>>>
>>> Motivation for this is the following SO question: http://stackoverflow.com/q/17844379/385378
>>>
> Changes merged. Small benchmark to verify that this indeed avoids the copy: https://gist.github.com/nikic/6398090 :)

Nikita,  IMO, this is a material performance optimisation of the PHP 
internals, as it removes one of the most common unnecessary (expensive) 
copies. So thanks for this.

It will be interesting to see the benefit on real apps such as 
MediaWiki.  I'll pull a 5.5 snapshot and compare it to 5.5.2 :-)

Regards
Terry